Re: [Nouveau] [PATCH v4 24/27] drm/vkms: Don't set struct drm_device.irq_enabled

From: Melissa Wen <melissa.srw@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: hamohammed.sa@gmail.com, heiko@sntech.de, emma@anholt.net,
	airlied@linux.ie, nouveau@lists.freedesktop.org,
	rodrigo.vivi@intel.com, liviu.dudau@arm.com,
	alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org,
	michal.simek@xilinx.com, linux-tegra@vger.kernel.org,
	thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com,
	linux@armlinux.org.uk, mihail.atanassov@arm.com,
	festevam@gmail.com, linux-stm32@st-md-mailman.stormreply.com,
	linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
	krzysztof.kozlowski@canonical.com,
	linux-rockchip@lists.infradead.org,
	linux-mediatek@lists.infradead.org, wens@csie.org,
	jernej.skrabec@gmail.com, xinliang.liu@linaro.org,
	kong.kongxinwei@hisilicon.com, james.qian.wang@arm.com,
	linux-imx@nxp.com, intel-gfx@lists.freedesktop.org,
	linux-graphics-maintainer@vmware.com,
	linux-sunxi@lists.linux.dev, bskeggs@redhat.com,
	chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
	puck.chen@hisilicon.com, s.hauer@pengutronix.de,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	inki.dae@samsung.com, rodrigosiqueiramelo@gmail.com,
	john.stultz@linaro.org, jani.nikula@linux.intel.com,
	laurentiu.palcu@oss.nxp.com, matthias.bgg@gmail.com,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	mcoquelin.stm32@gmail.com, amd-gfx@lists.freedesktop.org,
	hyun.kwon@xilinx.com, tomba@kernel.org, jyri.sarha@iki.fi,
	yannick.fertre@foss.st.com, Xinhui.Pan@amd.com,
	sw0312.kim@samsung.com, hjc@rock-chips.com,
	christian.koenig@amd.com, kyungmin.park@samsung.com,
	kieran.bingham+renesas@ideasonboard.com,
	philippe.cornu@foss.st.com, daniel@ffwll.ch,
	alexander.deucher@amd.com, tiantao6@hisilicon.com,
	shawnguo@kernel.org, brian.starkey@arm.com, zackr@vmware.com,
	l.stach@pengutronix.de
Subject: Re: [Nouveau] [PATCH v4 24/27] drm/vkms: Don't set struct drm_device.irq_enabled
Date: Sat, 26 Jun 2021 09:55:13 +0100	[thread overview]
Message-ID: <20210626085513.akf4cwyqpbchmycf@smtp.gmail.com> (raw)
In-Reply-To: <20210625082222.3845-25-tzimmermann@suse.de>

On 06/25, Thomas Zimmermann wrote:
> The field drm_device.irq_enabled is only used by legacy drivers
> with userspace modesetting. Don't set it in vkms.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I've also checked here, lgtm.

Reviewed-by: Melissa Wen <melissa.srw@gmail.com>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 027ffe759440..496de38ad983 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -163,8 +163,6 @@ static int vkms_create(struct vkms_config *config)
>  		goto out_devres;
>  	}
>  
> -	vkms_device->drm.irq_enabled = true;
> -
>  	ret = drm_vblank_init(&vkms_device->drm, 1);
>  	if (ret) {
>  		DRM_ERROR("Failed to vblank\n");
> -- 
> 2.32.0
> 
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau