archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
Cc: Greg Kroah-Hartman <>,, Ben Skeggs <>,
	Daniel Vetter <>,,
	Pekka Paalanen <>
Subject: [Nouveau] [PATCH 5.10 164/215] drm/nouveau: Dont set allow_fb_modifiers explicitly
Date: Thu, 15 Jul 2021 20:38:56 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Daniel Vetter <>

commit cee93c028288b9af02919f3bd8593ba61d1e610d upstream.


commit 890880ddfdbe256083170866e49c87618b706ac7
Author: Paul Kocialkowski <>
Date:   Fri Jan 4 09:56:10 2019 +0100

    drm: Auto-set allow_fb_modifiers when given modifiers at plane init

this is done automatically as part of plane init, if drivers set the
modifier list correctly. Which is the case here.

Note that this fixes an inconsistency: We've set the cap everywhere,
but only nv50+ supports modifiers. Hence cc stable, but not further
back then the patch from Paul.

Reviewed-by: Lyude Paul <>
Cc: # v5.1 +
Cc: Pekka Paalanen <>
Signed-off-by: Daniel Vetter <>
Cc: Ben Skeggs <>
Signed-off-by: Greg Kroah-Hartman <>

 drivers/gpu/drm/nouveau/nouveau_display.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -700,7 +700,6 @@ nouveau_display_create(struct drm_device
 	dev->mode_config.preferred_depth = 24;
 	dev->mode_config.prefer_shadow = 1;
-	dev->mode_config.allow_fb_modifiers = true;
 	if (drm-> < 0x11)
 		dev->mode_config.async_page_flip = false;

Nouveau mailing list

           reply	other threads:[~2021-07-15 18:51 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [Nouveau] [PATCH 5.10 164/215] drm/nouveau: Dont set allow_fb_modifiers explicitly' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).