nouveau.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak
@ 2021-09-11  7:50 Yang Yingliang
  2021-09-11  7:50 ` [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: " Yang Yingliang
  2021-09-28 11:33 ` [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: " Karol Herbst
  0 siblings, 2 replies; 4+ messages in thread
From: Yang Yingliang @ 2021-09-11  7:50 UTC (permalink / raw)
  To: linux-kernel, nouveau, dri-devel; +Cc: bskeggs

When using single_open() for opening, single_release() should be
called, otherwise the 'op' allocated in single_open() will be leaked.

Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c
index b8c31b697797..66f32d965c72 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/crc.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c
@@ -704,6 +704,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = {
 	.open = nv50_crc_debugfs_flip_threshold_open,
 	.read = seq_read,
 	.write = nv50_crc_debugfs_flip_threshold_set,
+	.release = single_release,
 };
 
 int nv50_head_crc_late_register(struct nv50_head *head)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: fix file release memory leak
  2021-09-11  7:50 [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak Yang Yingliang
@ 2021-09-11  7:50 ` Yang Yingliang
  2021-09-28 11:34   ` Karol Herbst
  2021-09-28 11:33 ` [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: " Karol Herbst
  1 sibling, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2021-09-11  7:50 UTC (permalink / raw)
  To: linux-kernel, nouveau, dri-devel; +Cc: bskeggs

When using single_open() for opening, single_release() should be
called, otherwise the 'op' allocated in single_open() will be leaked.

Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate interface ported to debugfs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/gpu/drm/nouveau/nouveau_debugfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
index c2bc05eb2e54..1cbe01048b93 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -207,6 +207,7 @@ static const struct file_operations nouveau_pstate_fops = {
 	.open = nouveau_debugfs_pstate_open,
 	.read = seq_read,
 	.write = nouveau_debugfs_pstate_set,
+	.release = single_release,
 };
 
 static struct drm_info_list nouveau_debugfs_list[] = {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak
  2021-09-11  7:50 [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak Yang Yingliang
  2021-09-11  7:50 ` [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: " Yang Yingliang
@ 2021-09-28 11:33 ` Karol Herbst
  1 sibling, 0 replies; 4+ messages in thread
From: Karol Herbst @ 2021-09-28 11:33 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: LKML, nouveau, dri-devel, Ben Skeggs

Reviewed-by: Karol Herbst <kherbst@redhat.com>

On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> When using single_open() for opening, single_release() should be
> called, otherwise the 'op' allocated in single_open() will be leaked.
>
> Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c
> index b8c31b697797..66f32d965c72 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c
> @@ -704,6 +704,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = {
>         .open = nv50_crc_debugfs_flip_threshold_open,
>         .read = seq_read,
>         .write = nv50_crc_debugfs_flip_threshold_set,
> +       .release = single_release,
>  };
>
>  int nv50_head_crc_late_register(struct nv50_head *head)
> --
> 2.25.1
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: fix file release memory leak
  2021-09-11  7:50 ` [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: " Yang Yingliang
@ 2021-09-28 11:34   ` Karol Herbst
  0 siblings, 0 replies; 4+ messages in thread
From: Karol Herbst @ 2021-09-28 11:34 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: LKML, nouveau, dri-devel, Ben Skeggs

Reviewed-by: Karol Herbst <kherbst@redhat.com>

On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> When using single_open() for opening, single_release() should be
> called, otherwise the 'op' allocated in single_open() will be leaked.
>
> Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate interface ported to debugfs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_debugfs.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> index c2bc05eb2e54..1cbe01048b93 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
> @@ -207,6 +207,7 @@ static const struct file_operations nouveau_pstate_fops = {
>         .open = nouveau_debugfs_pstate_open,
>         .read = seq_read,
>         .write = nouveau_debugfs_pstate_set,
> +       .release = single_release,
>  };
>
>  static struct drm_info_list nouveau_debugfs_list[] = {
> --
> 2.25.1
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-28 11:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11  7:50 [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak Yang Yingliang
2021-09-11  7:50 ` [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: " Yang Yingliang
2021-09-28 11:34   ` Karol Herbst
2021-09-28 11:33 ` [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: " Karol Herbst

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).