From: Jason Gunthorpe <jgg@ziepe.ca>
To: Christoph Hellwig <hch@lst.de>
Cc: "Linux NVDIMM" <nvdimm@lists.linux.dev>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
nouveau@lists.freedesktop.org,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Christian König" <christian.koenig@amd.com>,
"Linux MM" <linux-mm@kvack.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [Nouveau] [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount
Date: Wed, 9 Feb 2022 10:14:27 -0400 [thread overview]
Message-ID: <20220209141427.GJ49147@ziepe.ca> (raw)
In-Reply-To: <20220209135351.GA20631@lst.de>
On Wed, Feb 09, 2022 at 02:53:51PM +0100, Christoph Hellwig wrote:
> On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote:
> > It is nice, but the other series are still impacted by the fsdax mess
> > - they still stuff pages into ptes without proper refcounts and have
> > to carry nonsense to dance around this problem.
> >
> > I certainly would be unhappy if the amd driver, for instance, gained
> > the fsdax problem as well and started pushing 4k pages into PMDs.
>
> As said before: I think this all needs to be fixed. But I'd rather
> fix it gradually and I think this series is a nice step forward.
> After that we can look at the pte mappings.
Right, I agree with this
Jason
next prev parent reply other threads:[~2022-02-09 14:14 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 6:32 [Nouveau] start sorting out the ZONE_DEVICE refcount mess Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages Christoph Hellwig
2022-02-07 18:08 ` Dan Williams
2022-02-07 19:22 ` Jason Gunthorpe
2022-02-08 7:17 ` Chaitanya Kulkarni
2022-02-08 8:06 ` Muchun Song
2022-02-07 6:32 ` [Nouveau] [PATCH 2/8] mm: remove the __KERNEL__ guard from <linux/mm.h> Christoph Hellwig
2022-02-07 18:08 ` Dan Williams
2022-02-07 19:26 ` Jason Gunthorpe
2022-02-08 7:21 ` Chaitanya Kulkarni
2022-02-08 8:07 ` Muchun Song
2022-02-07 6:32 ` [Nouveau] [PATCH 3/8] mm: remove pointless includes from <linux/hmm.h> Christoph Hellwig
2022-02-07 14:01 ` Jason Gunthorpe
2022-02-08 7:27 ` Chaitanya Kulkarni
2022-02-07 6:32 ` [Nouveau] [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c Christoph Hellwig
2022-02-07 19:06 ` Dan Williams
2022-02-07 19:27 ` Jason Gunthorpe
2022-02-08 7:34 ` Chaitanya Kulkarni
2022-02-08 8:09 ` Muchun Song
2022-02-07 6:32 ` [Nouveau] [PATCH 5/8] mm: simplify freeing of devmap managed pages Christoph Hellwig
2022-02-07 19:34 ` Jason Gunthorpe
2022-02-07 23:42 ` Dan Williams
2022-02-08 7:50 ` Chaitanya Kulkarni
2022-02-07 6:32 ` [Nouveau] [PATCH 6/8] mm: don't include <linux/memremap.h> in <linux/mm.h> Christoph Hellwig
2022-02-07 17:38 ` Logan Gunthorpe
2022-02-07 19:35 ` Jason Gunthorpe
2022-02-07 21:19 ` Felix Kuehling
2022-02-08 6:46 ` Christoph Hellwig
2022-02-09 17:48 ` Christoph Hellwig
2022-02-10 2:10 ` Alistair Popple
2022-02-10 6:45 ` Christoph Hellwig
2022-02-10 21:00 ` Felix Kuehling
2022-02-07 23:49 ` Dan Williams
2022-02-08 23:53 ` Dan Williams
2022-02-09 6:22 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Christoph Hellwig
2022-02-07 19:21 ` Jason Gunthorpe
2022-02-08 2:25 ` Ralph Campbell
2022-02-09 3:30 ` Dan Williams
2022-02-09 6:23 ` Christoph Hellwig
2022-02-09 12:29 ` Jason Gunthorpe
2022-02-09 13:53 ` Christoph Hellwig
2022-02-09 14:14 ` Jason Gunthorpe [this message]
2022-02-07 6:32 ` [Nouveau] [PATCH 8/8] fsdax: depend on ZONE_DEVICE || FS_DAX_LIMITED Christoph Hellwig
2022-02-07 19:36 ` Jason Gunthorpe
2022-02-07 23:51 ` [Nouveau] start sorting out the ZONE_DEVICE refcount mess Logan Gunthorpe
2022-02-08 3:03 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209141427.GJ49147@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Felix.Kuehling@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=nouveau@lists.freedesktop.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).