* [Nouveau] [PATCH] drm: nouveau: move bounds checking to the front in nouveau_svm_fault_buffer_dtor()
@ 2022-09-14 7:10 Hangyu Hua
0 siblings, 0 replies; only message in thread
From: Hangyu Hua @ 2022-09-14 7:10 UTC (permalink / raw)
To: bskeggs, kherbst, lyude, airlied, daniel
Cc: nouveau, linux-kernel, dri-devel, Hangyu Hua
It is better to check i before use it in array to avoid potential out of
bound access.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c
index 31a5b81ee9fc..5c49a8eaf593 100644
--- a/drivers/gpu/drm/nouveau/nouveau_svm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
@@ -957,7 +957,7 @@ nouveau_svm_fault_buffer_dtor(struct nouveau_svm *svm, int id)
int i;
if (buffer->fault) {
- for (i = 0; buffer->fault[i] && i < buffer->entries; i++)
+ for (i = 0; i < buffer->entries && buffer->fault[i]; i++)
kfree(buffer->fault[i]);
kvfree(buffer->fault);
}
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-20 21:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 7:10 [Nouveau] [PATCH] drm: nouveau: move bounds checking to the front in nouveau_svm_fault_buffer_dtor() Hangyu Hua
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).