From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70045C433FE for ; Tue, 5 Oct 2021 20:26:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 423D4603E5 for ; Tue, 5 Oct 2021 20:26:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 423D4603E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD63B6EC4C; Tue, 5 Oct 2021 20:26:33 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7DFE6EC46 for ; Tue, 5 Oct 2021 20:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633465591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZSF6jCxZJ9Lo/pAWpdyqwfRutIttoAnBdF2YSZZDlW0=; b=cTAgbHmQr573ZEqQ9abysLcVDl0vtP7syR4NiFM0C2M4FPXPCtL2XMHdm6rrv9xlLwWxdu BIERNkh95UITUKpE7OkOpaSYgplPiQpKEP7niEXZr1y1KDLMMOBqlM/vOv25JFLKPc/3Uv /GOt87FywMXm+vITGauBGcvWSD+Q+d0= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-nX2qyMbCNDqisqydDhB0xg-1; Tue, 05 Oct 2021 16:26:30 -0400 X-MC-Unique: nX2qyMbCNDqisqydDhB0xg-1 Received: by mail-qk1-f200.google.com with SMTP id v14-20020a05620a0f0e00b0043355ed67d1so195620qkl.7 for ; Tue, 05 Oct 2021 13:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=ZSF6jCxZJ9Lo/pAWpdyqwfRutIttoAnBdF2YSZZDlW0=; b=zAo6TnvLjYmqiUWliLU8JomwFZnOGtjRwEnyEHrDLqc5GdIswicy2F7GZIvktQEFDM uImDMenYLBgbgWDILFq9lAEnAhU1eRRLATZJvM9G3kUj9mYl3jEgiIFsm+dv3HLkbFgm EV4NGqemzDy4a9RcFdbpvWOYh2U6CytSpUsitozbB8j0bWG4u9w0FWn+G+KRhSaXH0CK /FxjQAVksVzirbsvEPinKS/KSQhhpkZt4CkrC6KxND7U/nlCOQiWdkHBmCX/Y6jMH0gC oiY54za9hRqhiNQ+8Y8Db/6STBtw15U/8BIRZ6FN47XU51qKL8TjLLCTayKXvpAqN0xQ lJmQ== X-Gm-Message-State: AOAM5337XjZizQBL0ImDlIVByurw57eaSxdOUPoUNWzsNnZDs7tXkNY+ s+QJn4AHzdYknn1bjwf9ujNcAr8h93s6S9J9PHFP9eDL3z2zgNtphkF1RbssyBFxP9Vr4/T3bB9 X9cKSyDKl9oCjooFmN+BgfqCfAw== X-Received: by 2002:ac8:7594:: with SMTP id s20mr21704093qtq.158.1633465589735; Tue, 05 Oct 2021 13:26:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFGL8CYgwl0+YAqpEiDKaGURHpezzUi3uShlPK4PU7tYdF8F4X2cRWBAsEQwveFxTDxgtvuA== X-Received: by 2002:ac8:7594:: with SMTP id s20mr21704076qtq.158.1633465589546; Tue, 05 Oct 2021 13:26:29 -0700 (PDT) Received: from [192.168.8.206] (pool-96-230-249-157.bstnma.fios.verizon.net. [96.230.249.157]) by smtp.gmail.com with ESMTPSA id a16sm10017550qkn.16.2021.10.05.13.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 13:26:29 -0700 (PDT) Message-ID: <2b04c75841f4c1661c242a3371b12d52bb0573ef.camel@redhat.com> From: Lyude Paul To: Hans de Goede , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Date: Tue, 05 Oct 2021 16:26:28 -0400 In-Reply-To: References: <20211001225344.1752203-1-lyude@redhat.com> Organization: Red Hat User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Nouveau] [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Sat, 2021-10-02 at 11:14 +0200, Hans de Goede wrote: > Hi Lyude, > > On 10/2/21 12:53 AM, Lyude Paul wrote: > > When I originally moved all of the VESA backlight code in i915 into DRM > > helpers, one of the things I didn't have the hardware or time for > > testing was machines that used a combination of PWM and DPCD in order to > > control their backlights. This has since then caused some breakages and > > resulted in us disabling DPCD backlight support on such machines. This > > works fine, unless you have a machine that actually needs this > > functionality for backlight controls to work at all. Additionally, we > > will need to support PWM for when we start adding support for VESA's > > product (as in the product of multiplication) control mode for better > > brightness ranges. > > > > So - let's finally finish up implementing basic support for these types > > of backlights to solve these problems in our DP helpers, along with > > implementing support for this in i915. And since digging into this issue > > solved the last questions we really had about probing backlights in i915 > > for the most part, let's update some of the comments around that as > > well! > > Backlight control is a topic which I'm reasonably familiar with, > do you want me to review this series for you ? Possibly, although I definitely want to make sure that someone from Intel gets a chance to review this as well. I'm more curious if you might happen to have any systems that would be able to test this. > > Regards, > > Hans > > > > > > > Changes: > > * Fixup docs > > * Add patch to stop us from breaking nouveau > > > > Lyude Paul (4): > >   drm/i915: Add support for panels with VESA backlights with PWM > >     enable/disable > >   drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux > >     enable/brightness > >   drm/dp, drm/i915: Add support for VESA backlights using PWM for > >     brightness control > >   drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs() > > > >  drivers/gpu/drm/drm_dp_helper.c               | 75 +++++++++++------ > >  .../drm/i915/display/intel_dp_aux_backlight.c | 80 ++++++++++++++----- > >  drivers/gpu/drm/nouveau/nouveau_backlight.c   |  5 +- > >  include/drm/drm_dp_helper.h                   |  7 +- > >  4 files changed, 122 insertions(+), 45 deletions(-) > > > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat