From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4366C433EF for ; Fri, 5 Nov 2021 14:25:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 691526044F for ; Fri, 5 Nov 2021 14:25:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 691526044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7193E6E8F0; Fri, 5 Nov 2021 14:25:41 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D312089CD4 for ; Fri, 5 Nov 2021 12:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636113674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d6mnjEfsvPWlmw0Dlsyl+1vpuoyclHqeKNkGqPRjBhA=; b=blUsf+DphCkAa2HzUFHJk6+P+VzzwtzOxDAyn5bgR5WNRZGlPXWs1j2BdkXG88YOnqg8Ay TO/sHz4yO/A7M742m4XkmdR1n4lr3z2kNopkY2ejELFhcmmoazFDDpNlPudMu7hH2+8kb4 SaT2zuHLgAHlqMsJYaQk3CKa5l7A+fk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-pw16T3ipPOy92JRCy_p5sw-1; Fri, 05 Nov 2021 08:00:52 -0400 X-MC-Unique: pw16T3ipPOy92JRCy_p5sw-1 Received: by mail-wm1-f72.google.com with SMTP id o10-20020a05600c4fca00b0033312e1ed8bso510128wmq.2 for ; Fri, 05 Nov 2021 05:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=d6mnjEfsvPWlmw0Dlsyl+1vpuoyclHqeKNkGqPRjBhA=; b=B/t1NywQR3XXuh2kSlKEVRqknJDGK1kLvGOpFcgr+mn02nyeN+Bn4bnVxuaYmxJp2o 9+smzkXprMcD7agcUdGGyLkYkpbJgsSDCCJ8dJaHWc1NyedgovdYdM854WWYc/lsrmwF zllGfxZ4pYGo9/Q7vrVw6CYRzMh5EnRMSytEvtCkY0U84y+YVY+3PkON5fZv5EWw1cKh OTvtsVdg9Qky/VU8cJgdTlzaRExv2dbKHLcIA2xAavjnZYXN8KrUWtGHej2cGsQT47xH vPuZHzuWaKpEfBhTHjKKncQg11xyc7+MuYi6hadK8gt82iPLQhf6m+qAgfUwT9oa/26w vNfw== X-Gm-Message-State: AOAM5327RIsPIk+yaKuJPeK5t0Q4482MmF2x2cnoEr9sTZWo2gcTNlb3 88Jlc4Iu0L+UNF0ZWfVh9m4++WPJuhC7+3KyqAP7FZOp3K9fXQKGzj6Px9adB/6UC6LdTXAjwtr QbtnShTJmldO/3bugIR4tzh6ENA== X-Received: by 2002:a05:6000:1868:: with SMTP id d8mr36559135wri.285.1636113651757; Fri, 05 Nov 2021 05:00:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxlHaNU9FU6Qy+ImAOwcqW/sLneLxZOG0rukxfbYjqJBdrwuSz7fg+xp3pWIymRwt/FJOPRA== X-Received: by 2002:a05:6000:1868:: with SMTP id d8mr36559073wri.285.1636113651479; Fri, 05 Nov 2021 05:00:51 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id m21sm7590336wrb.2.2021.11.05.05.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 05:00:51 -0700 (PDT) Message-ID: <335a9e0f-cce9-480b-10e0-bd312b81e587@redhat.com> Date: Fri, 5 Nov 2021 13:00:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Jani Nikula , Thomas Zimmermann , linux-kernel@vger.kernel.org References: <20211104160707.1407052-1-javierm@redhat.com> <20211104160707.1407052-2-javierm@redhat.com> <87ilx7ae3v.fsf@intel.com> <0c07f121-42d3-9f37-1e14-842fb685b501@redhat.com> <38dbcc8f-2f95-6846-537f-9b85468bfa87@redhat.com> <877ddmapfj.fsf@intel.com> From: Javier Martinez Canillas In-Reply-To: <877ddmapfj.fsf@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 05 Nov 2021 14:25:39 +0000 Subject: Re: [Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pan, Xinhui" , Pekka Paalanen , Hans de Goede , David Airlie , dri-devel@lists.freedesktop.org, Rodrigo Vivi , amd-gfx@lists.freedesktop.org, Gurchetan Singh , Ben Skeggs , VMware Graphics , Gerd Hoffmann , spice-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Alex Deucher , Dave Airlie , =?UTF-8?Q?Christian_K=c3=b6nig?= , virtualization@lists.linux-foundation.org, intel-gfx@lists.freedesktop.org, =?UTF-8?Q?Michel_D=c3=a4nzer?= , Peter Robinson Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On 11/5/21 11:04, Jani Nikula wrote: > On Fri, 05 Nov 2021, Javier Martinez Canillas wrote: [snip] >> >> Do you envision other condition that could be added later to disable a >> DRM driver ? Or do you think that just from a code readability point of >> view makes worth it ? > > Taking a step back for perspective. > > I think there's broad consensus in moving the parameter to drm, naming > the check function to drm_something_something(), and breaking the ties > to CONFIG_VGA_CONSOLE. I appreciate the work you're doing to that > effect. > Thanks, I appreciate your feedback and comments. > I think everything beyond that is still a bit vague and/or > contentious. So how about making the first 2-3 patches just that? > Something we can all agree on, makes good progress, improves the kernel, > and gives us something to build on? > That works for me. Thomas, do you agree with that approach ? Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat