From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94E6FC433EF for ; Fri, 21 Jan 2022 01:48:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE50310E590; Fri, 21 Jan 2022 01:48:18 +0000 (UTC) X-Greylist: delayed 605 seconds by postgrey-1.36 at gabe; Fri, 21 Jan 2022 01:48:16 UTC Received: from relay.hostedemail.com (relay031.a.hostedemail.com [64.99.140.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6AE110E590; Fri, 21 Jan 2022 01:48:16 +0000 (UTC) Received: from omf06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DAEDB22DB5; Fri, 21 Jan 2022 01:38:07 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id 3264F20010; Fri, 21 Jan 2022 01:37:54 +0000 (UTC) Message-ID: <5da3e02454c8c9ff3335c7199f3ae48af2864981.camel@perches.com> From: Joe Perches To: Steven Rostedt , Andy Shevchenko Date: Thu, 20 Jan 2022 17:37:53 -0800 In-Reply-To: <20220119160017.65bd1fa5@gandalf.local.home> References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> <20220119100635.6c45372b@gandalf.local.home> <20220119160017.65bd1fa5@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: 7rtkhruhzyxmaz9kz4md8szkb6csicqt X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 3264F20010 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+2KBCQ3/oG0QJHNmpFhxNu1Bw+ZDwRWLg= X-HE-Tag: 1642729074-280175 Subject: Re: [Nouveau] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , David Airlie , nouveau@lists.freedesktop.org, Joonas Lahtinen , Rasmus Villemoes , dri-devel@lists.freedesktop.org, Chris Wilson , Vishal Kulkarni , Francis Laniel , Kentaro Takeda , amd-gfx@lists.freedesktop.org, Ben Skeggs , Jakub Kicinski , Harry Wentland , Petr Mladek , Sakari Ailus , Leo Li , intel-gfx@lists.freedesktop.org, Raju Rangoju , Lucas De Marchi , Jani Nikula , Julia Lawall , Rahul Lakkireddy , Rodrigo Vivi , Mikita Lipski , Eryk Brol , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Christian =?ISO-8859-1?Q?K=F6nig?= , Sergey Senozhatsky , linux-security-module@vger.kernel.org, Daniel Vetter , netdev@vger.kernel.org, Alex Deucher , Andrew Morton , "David S . Miller" Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, 2022-01-19 at 16:00 -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 21:25:08 +0200 > Andy Shevchenko wrote: > > > > I say keep it one line! > > > > > > Reviewed-by: Steven Rostedt (Google) > > > > I believe Sakari strongly follows the 80 rule, which means... > > Checkpatch says "100" I think we need to simply update the docs (the > documentation always lags the code ;-) checkpatch doesn't say anything normally, it's a stupid script. It just mindlessly bleats a message when a line exceeds 100 chars... Just fyi: I think it's nicer on a single line too.