From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D05C433DB for ; Fri, 26 Mar 2021 21:41:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90D3D619F9 for ; Fri, 26 Mar 2021 21:41:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90D3D619F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EF1D6F48F; Fri, 26 Mar 2021 21:41:14 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B0956F48F for ; Fri, 26 Mar 2021 21:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616794871; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KYq2FimxUUOirhAHH7Y6K62w8Nvf75VdOPqqjNoVNY=; b=W5kIHebJFQc18Y0CiqW8irbi+yugpbtF94Y3AXlZy/RWXcs9dmdAbm26lO1qTfPrwwYUGJ 2Hufszqz8YhU73oDq88VuLQoNcthR0WFsB6uuPf671okGacBAufeZPqxRDfYCgoqS1iAux rACOcu6ZjPUAOJs8+XWVXnYXmRlQVEE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426-ZoQ1bJSZNVKG2Ifodo3ubw-1; Fri, 26 Mar 2021 17:41:07 -0400 X-MC-Unique: ZoQ1bJSZNVKG2Ifodo3ubw-1 Received: by mail-qv1-f71.google.com with SMTP id x20so6627315qvd.21 for ; Fri, 26 Mar 2021 14:41:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=2KYq2FimxUUOirhAHH7Y6K62w8Nvf75VdOPqqjNoVNY=; b=emNfDLf63/L7saZ6ybK21p/cx1GKwExkd0G4EnGhYDgYWGSqzhWlpwzKsp7JjfnG0r YTclBqkGs0vMT7Acg1Uo48yYNTTjm/fJBJkllliKLYds4iseWecsWfo2SCXUXRm+qcXy R0qHtxCu/nWcLLstCvCyDaC8ZGt8lIbpTsuN8zsk8/OJXReHaQhT81amt/6GqetcguU9 z1XE0xcKKpGaT+RQkvRLegSvAHhPrcK+UULoPLnlk2Ln4HqqcZZ3FSOFrXAVLgQwIKax KS4tJRdF9Vh2dcVQaZq974WOLZ3vR3pAYcLvPjh/LghVPh8X4M49339S4/eLrhF4k/Jc M7gQ== X-Gm-Message-State: AOAM532WtqY0Z8Gg/8xuT8pwh29JF/6TRvyrJ9dz9jQP9sFO6oabRlY4 Dooc/7V+K8AA5YFLgFl4HXOUnewBFBPYaXfDaV3rKpT5YPJU2An1Uw3NU+vHgqifpI+Alo1B1Vb +q9Kgozf4yEw+0UmDoFkp3sfp5Q== X-Received: by 2002:ac8:6789:: with SMTP id b9mr13776317qtp.103.1616794866635; Fri, 26 Mar 2021 14:41:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc8vW+QMW0U4nq1pb7zDYcwAwcJWPPX3yqc5y79GrncUcdi02PbcBkqm4COvoGtyLpXgXAgg== X-Received: by 2002:ac8:6789:: with SMTP id b9mr13776303qtp.103.1616794866456; Fri, 26 Mar 2021 14:41:06 -0700 (PDT) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id l9sm6725962qtv.65.2021.03.26.14.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 14:41:05 -0700 (PDT) Message-ID: <7f51dbe3dac85f692e01bb5cecdf4454a40b1893.camel@redhat.com> From: Lyude Paul To: Jeremy Cline , Ben Skeggs Date: Fri, 26 Mar 2021 17:41:05 -0400 In-Reply-To: <20201203000220.18238-1-jcline@redhat.com> References: <20201203000220.18238-1-jcline@redhat.com> Organization: Red Hat User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Nouveau] [PATCH] drm/nouveau: avoid a use-after-free when BO init fails X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lyude@redhat.com Cc: David Airlie , nouveau@lists.freedesktop.org, Thierry Reding , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" UmV2aWV3ZWQtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+CgpPbiBXZWQsIDIwMjAt MTItMDIgYXQgMTk6MDIgLTA1MDAsIEplcmVteSBDbGluZSB3cm90ZToKPiBub3V2ZWF1X2JvX2lu aXQoKSBpcyBiYWNrZWQgYnkgdHRtX2JvX2luaXQoKSBhbmQgZmVycmllcyBpdHMgcmV0dXJuIGNv ZGUKPiBiYWNrIHRvIHRoZSBjYWxsZXIuIE9uIGZhaWx1cmVzLCB0dG1fYm9faW5pdCgpIGludm9r ZXMgdGhlIHByb3ZpZGVkCj4gZGVzdHJ1Y3RvciB3aGljaCBzaG91bGQgZGUtaW5pdGlhbGl6ZSBh bmQgZnJlZSB0aGUgbWVtb3J5Lgo+IAo+IFRodXMsIHdoZW4gbm91dmVhdV9ib19pbml0KCkgcmV0 dXJucyBhbiBlcnJvciB0aGUgZ2VtIG9iamVjdCBoYXMgYWxyZWFkeQo+IGJlZW4gcmVsZWFzZWQg YW5kIHRoZSBtZW1vcnkgZnJlZWQgYnkgbm91dmVhdV9ib19kZWxfdHRtKCkuCj4gCj4gRml4ZXM6 IDAxOWNiZDRhNGZlYiAoImRybS9ub3V2ZWF1OiBJbml0aWFsaXplIEdFTSBvYmplY3QgYmVmb3Jl IFRUTSBvYmplY3QiKQo+IENjOiBUaGllcnJ5IFJlZGluZyA8dHJlZGluZ0BudmlkaWEuY29tPgo+ IFNpZ25lZC1vZmYtYnk6IEplcmVteSBDbGluZSA8amNsaW5lQHJlZGhhdC5jb20+Cj4gLS0tCj4g wqBkcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2dlbS5jIHwgNCArLS0tCj4gwqAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZ2VtLmMKPiBiL2RyaXZlcnMvZ3B1 L2RybS9ub3V2ZWF1L25vdXZlYXVfZ2VtLmMKPiBpbmRleCA3ODdkMDVlZWZkOWMuLmQzMDE1N2Nj NzE2OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2dlbS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9nZW0uYwo+IEBAIC0yMTEs MTAgKzIxMSw4IEBAIG5vdXZlYXVfZ2VtX25ldyhzdHJ1Y3Qgbm91dmVhdV9jbGkgKmNsaSwgdTY0 IHNpemUsIGludAo+IGFsaWduLCB1aW50MzJfdCBkb21haW4sCj4gwqDCoMKgwqDCoMKgwqDCoH0K PiDCoAo+IMKgwqDCoMKgwqDCoMKgwqByZXQgPSBub3V2ZWF1X2JvX2luaXQobnZibywgc2l6ZSwg YWxpZ24sIGRvbWFpbiwgTlVMTCwgTlVMTCk7Cj4gLcKgwqDCoMKgwqDCoMKgaWYgKHJldCkgewo+ IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBub3V2ZWF1X2JvX3JlZihOVUxMLCAmbnZi byk7Cj4gK8KgwqDCoMKgwqDCoMKgaWYgKHJldCkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoHJldHVybiByZXQ7Cj4gLcKgwqDCoMKgwqDCoMKgfQo+IMKgCj4gwqDCoMKgwqDCoMKg wqDCoC8qIHdlIHJlc3RyaWN0IGFsbG93ZWQgZG9tYWlucyBvbiBudjUwKyB0byBvbmx5IHRoZSB0 eXBlcwo+IMKgwqDCoMKgwqDCoMKgwqAgKiB0aGF0IHdlcmUgcmVxdWVzdGVkIGF0IGNyZWF0aW9u IHRpbWUuwqAgbm90IHBvc3NpYmx5IG9uCgotLSAKU2luY2VyZWx5LAogICBMeXVkZSBQYXVsIChz aGUvaGVyKQogICBTb2Z0d2FyZSBFbmdpbmVlciBhdCBSZWQgSGF0CiAgIApOb3RlOiBJIGRlYWwg d2l0aCBhIGxvdCBvZiBlbWFpbHMgYW5kIGhhdmUgYSBsb3Qgb2YgYnVncyBvbiBteSBwbGF0ZS4g SWYgeW91J3ZlCmFza2VkIG1lIGEgcXVlc3Rpb24sIGFyZSB3YWl0aW5nIGZvciBhIHJldmlldy9t ZXJnZSBvbiBhIHBhdGNoLCBldGMuIGFuZCBJCmhhdmVuJ3QgcmVzcG9uZGVkIGluIGEgd2hpbGUs IHBsZWFzZSBmZWVsIGZyZWUgdG8gc2VuZCBtZSBhbm90aGVyIGVtYWlsIHRvIGNoZWNrCm9uIG15 IHN0YXR1cy4gSSBkb24ndCBiaXRlIQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9u b3V2ZWF1Cg==