From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
mripard@kernel.org, maarten.lankhorst@linux.intel.com,
airlied@linux.ie, daniel@ffwll.ch
Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org,
freedreno@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Nouveau] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module
Date: Mon, 13 Dec 2021 15:34:12 +0200 [thread overview]
Message-ID: <87lf0o7hnv.fsf@intel.com> (raw)
In-Reply-To: <20211213093650.19598-1-tzimmermann@suse.de>
On Mon, 13 Dec 2021, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Split-off DisplayPort functions from KMS helper library and move them
> into their own module. Reduces the size of drm_kms_helper.ko by ~50%.
>
> This patchset is part of an on-going effort to reduce the minimum
> binary size of the DRM core and helpers. It's helpful for systems with
> early-boot DRM graphics, which requires DRM to be linked into the
> kernel image.
Would it be time to add a subdirectory for each non-driver, non-core drm
module? We've touched this topic before. I find it increasingly hard to
remember which files are part of helpers. This would also help with the
arbitrary drm_dp_helper_mod.c naming.
Perhaps drivers/gpu/drm/drm_dp/?
BR,
Jani.
>
> Thomas Zimmermann (3):
> drm/dp_mst: Remove trailing whitespace.
> drm/dp: Move DP declarations into separate header file
> drm/dp: Move DisplayPort helpers into separate helper module
>
> drivers/gpu/drm/Kconfig | 8 ++++++
> drivers/gpu/drm/Makefile | 14 ++++++----
> drivers/gpu/drm/bridge/Kconfig | 4 +++
> drivers/gpu/drm/bridge/analogix/Kconfig | 2 ++
> drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
> drivers/gpu/drm/drm_crtc_helper_internal.h | 27 ------------------
> drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} | 2 +-
> drivers/gpu/drm/drm_dp_aux_dev.c | 2 +-
> drivers/gpu/drm/drm_dp_helper_internal.h | 28 +++++++++++++++++++
> drivers/gpu/drm/drm_dp_helper_mod.c | 22 +++++++++++++++
> drivers/gpu/drm/drm_dp_mst_topology.c | 4 +--
> drivers/gpu/drm/drm_kms_helper_common.c | 14 ----------
> drivers/gpu/drm/i915/Kconfig | 1 +
> drivers/gpu/drm/msm/Kconfig | 1 +
> drivers/gpu/drm/nouveau/Kconfig | 1 +
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> drivers/gpu/drm/tegra/Kconfig | 1 +
> drivers/gpu/drm/xlnx/Kconfig | 1 +
> 18 files changed, 83 insertions(+), 51 deletions(-)
> rename drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} (99%)
> create mode 100644 drivers/gpu/drm/drm_dp_helper_internal.h
> create mode 100644 drivers/gpu/drm/drm_dp_helper_mod.c
>
>
> base-commit: 3f422828221d9ceefcddef0be33561b1646a1cbe
> prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
> --
> 2.34.1
>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-12-13 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 9:36 [Nouveau] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module Thomas Zimmermann
2021-12-13 9:36 ` [Nouveau] [PATCH 1/3] drm/dp_mst: Remove trailing whitespace Thomas Zimmermann
2021-12-13 9:36 ` [Nouveau] [PATCH 2/3] drm/dp: Move DP declarations into separate header file Thomas Zimmermann
2021-12-13 9:59 ` [Nouveau] [Intel-gfx] " Jani Nikula
2021-12-13 9:36 ` [Nouveau] [PATCH 3/3] drm/dp: Move DisplayPort helpers into separate helper module Thomas Zimmermann
2021-12-13 13:34 ` Jani Nikula [this message]
2021-12-13 13:51 ` [Nouveau] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module Thomas Zimmermann
2021-12-15 10:24 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf0o7hnv.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).