From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3722C433F5 for ; Sat, 12 Feb 2022 17:00:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A3E710E30E; Sat, 12 Feb 2022 17:00:01 +0000 (UTC) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3835310EA27; Fri, 11 Feb 2022 09:00:56 +0000 (UTC) Received: by mail-pf1-x436.google.com with SMTP id n23so15150160pfo.1; Fri, 11 Feb 2022 01:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TYfaiwKavc3e6ks5kgUb85H+DdokL0giIO6Sl6/ijvM=; b=YirJZ/OrUY1KZE/c6Pg4WKdA/DVfcwtcmgwJ5LeUBhEbafCWoTh9dRaxYHbAAlx5/C U2C+6mW0+lJAlHWtOg6Jfruy1phkB55fCjanV518XXMonO4Hm6ZSmv0a+hkiWX4Xf2l2 F9WP7bUMgjY+zB++WmbReucO/ta2ZBOXgrg92r7OGhkWQy37UA+S//xb9jpWn5ZKj96y LnpuDVcC32NCF4RZ+6aqEftgT8/PJdiEZnC+VclBeG3Ei8dWYSEKoWoxv52Zf/WhHGnV 07bulekwlPGroFxqE2alC/bi7t4P/vt0jqRGa474mzrGuPqiaFj5qHcTUhc6uew3QFCw KNyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TYfaiwKavc3e6ks5kgUb85H+DdokL0giIO6Sl6/ijvM=; b=MuvnwSIpa+QRzcC3Rc5w2fpUWi05xaSUfLnteha2U7gBv9igKYuB0wynCu2tsLeOFI Zl/HDAld1iq3kq0jNXHPKhy82dHnFjuZr0fZ234vjUpwci8SXJ3KhbrCV6eGubb+h2DS y5HVOumflR1dl8PbuRrtnW+bIJHrfQ+lMsECqtUroCO+4DerpF0xOGcJJhZ5S/Rz8DUW o7GdaS9uR1EeRCLYkou0qlRhW2Eil6fANb9n/rZyMs9rqh1C+5fcHQpojq9rgp0FPI3g VbXZcI6McoZy490XMaqblk7x75i72SEOVMGO5tA6uyMGYkii+rCQgABE/Dep/f49RNJv CvKg== X-Gm-Message-State: AOAM531bgSN06zZboAIYKoO3AKxmiFVY7IKkCPHd5EPiIzJv7QgMXnKv JVAM8Vsr4UQZrGinopK33oxfVRilteltTa3DkS0= X-Google-Smtp-Source: ABdhPJzcBNwwDsrsLQTMfyhXlsVQPJ2eITAU351K13T2qQrMZreubqDuNlWvqA9y1Wv+mW0Rsuhg0no4yZY/uUPEJeI= X-Received: by 2002:a05:6a00:2310:: with SMTP id h16mr697184pfh.80.1644570055706; Fri, 11 Feb 2022 01:00:55 -0800 (PST) MIME-Version: 1.0 References: <20220210224329.2793-1-mario.limonciello@amd.com> <20220210224329.2793-9-mario.limonciello@amd.com> In-Reply-To: <20220210224329.2793-9-mario.limonciello@amd.com> From: Yehezkel Bernat Date: Fri, 11 Feb 2022 11:00:39 +0200 Message-ID: To: Mario Limonciello Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sat, 12 Feb 2022 16:59:59 +0000 Subject: Re: [Nouveau] [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached` X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Jamet , "open list:PCI SUBSYSTEM" , "open list:THUNDERBOLT DRIVER" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:X86 PLATFORM DRIVERS" , Andreas Noever , "open list:DRM DRIVERS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , Bjorn Helgaas , Alexander.Deucher@amd.com, Mika Westerberg Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Fri, Feb 11, 2022 at 12:43 AM Mario Limonciello wrote: > > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > Maybe it's only me, but isn't it a bit strange to keep this function named `is_thunderbolt` while it's actually about being removable?