From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE47C4338F for ; Wed, 4 Aug 2021 22:02:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F78D6105A for ; Wed, 4 Aug 2021 22:02:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F78D6105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 57DA16E1A2; Wed, 4 Aug 2021 22:02:04 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB8CB6E1BA for ; Wed, 4 Aug 2021 22:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628114522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d2KqUld+afo/DqE9+AEtQTsC0qFJZ5g464VDzN5fDCk=; b=PEWptoFKrUobOBdl0FKLvhywAbaTnDi0Y5K/22flmid4nP9d5qEwg+E3y/SDgKG6VZXbZy 2exaXo+HWw2CA8y0PuVLk4GTAHwaBQaZQTHFAcyYfU4LPMs12lwQ2zNRyArrT1N3p3vk0K sJfOnN8om8QoX+uWOCUrNaMDdumWfJM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-cA76E8RlMiK_ThauRPv0_g-1; Wed, 04 Aug 2021 18:01:59 -0400 X-MC-Unique: cA76E8RlMiK_ThauRPv0_g-1 Received: by mail-wm1-f70.google.com with SMTP id y186-20020a1c32c30000b02902b5ac887cfcso796158wmy.2 for ; Wed, 04 Aug 2021 15:01:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d2KqUld+afo/DqE9+AEtQTsC0qFJZ5g464VDzN5fDCk=; b=G4cgC3nRbA0Dw7hLRGYEYhHcQjjnRX+wgcxPsHDi/GO8FOL4GztjtzEMzQ/vl8ZK4k vR8Xp6pWFvKfY9IZxH6laGbLKumBuYjcc1Ao4qMoNR14j1Zpd19AEYijZgqX+3a7qUfl PMP95BFJ9ZmN1GOfokTpAmakzBC1iD5vMzDwzlvPa7JBoEV8iSs1TdB/EVIP/bZCt9dK 3eDsnV4ob9CNO968YOpQ/Dmgad7NGbrypKLxDz8Ai9Y3uYHqbnnJ+VwRMbPMm8W8QsE3 daRG4Osokh4mpMbb0isbRWDtDnmwwbgZPKw8rLNZL940Ps3u03n5rFc1LPmwYyyrWUPZ 3hGQ== X-Gm-Message-State: AOAM531Bu60n+FXe6P8/lTiE/TJYTIm+/CDSik950Ly6uMfvI0p/cLTF EbbxxwBYr8aR7m7y84eERcMEy6WL055ZSlf8BbYZaoznkngegFjN2AsTQnn6r4w7BvOhvZorKyt KzDzKWICoUqj+10Eh3d3FZtXJNWoZyxh3VhP57++4gA== X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr11802094wmm.171.1628114518451; Wed, 04 Aug 2021 15:01:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY5/nXWklNR1mjmCS911U1388HsPu+p770sIXPA+rC70wi12iHVm9penxHkIrsLojhFxJ+H/cT1xS0GAj+5BQ= X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr11802083wmm.171.1628114518302; Wed, 04 Aug 2021 15:01:58 -0700 (PDT) MIME-Version: 1.0 References: <20210804141049.499767-1-kherbst@redhat.com> In-Reply-To: From: Karol Herbst Date: Thu, 5 Aug 2021 00:01:47 +0200 Message-ID: To: Arnd Bergmann Cc: Linux Kernel Mailing List , Lyude Paul , Ben Skeggs , Randy Dunlap , Daniel Vetter , ML nouveau , dri-devel Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > > > playing around a little bit with this, I think the original "select > > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > > drivers selecting and others depending on it. We could of course convert > > > > > everything over to depend, and break those cycling dependency issues with > > > > > this. > > > > > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > > > happy and has the advantage of not having to mess with the deps of nouveau > > > > > too much. > > > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > > keep working. > > > > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > > BACKLIGHT_CLASS_DEVICE might be disabled :( > > Are you sure? It should already be the case that any driver that selects > FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' > or 'select BACKLIGHT_CLASS_DEVICE'. > none of the fb drivers seem to do that. > If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends > on', I don't see a problem with doing 'select FB_BACKLIGHT' from > those. > > I have applied your patch to my randconfig tree and built a few dozen > kernels, don't see any regressions so far, but will let it run over night. > > Arnd >