From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2B4C433F5 for ; Tue, 28 Sep 2021 11:14:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3975D61159 for ; Tue, 28 Sep 2021 11:14:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3975D61159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF8E86E10D; Tue, 28 Sep 2021 11:14:48 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 867656E10D for ; Tue, 28 Sep 2021 11:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632827685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZU+KVR0y2VTh3ZrdA51D/L+4k30fXIYJ6SUmvuXTBtU=; b=SAKOM0YqFwuNKPwYKLal4VIfwogfEf2saQ2GH0A68F4bAAdDXVXHuhGWaVJQb1WZf9oyKc RjGMO/dyJlmy9yXkH/YNpWf9bs8BoilrI4/AYWwfytmV+n5x9BJ8QhlVhjgTsXRTS6VRU0 +HhvCiDMJNYbN7VtgT7wdXOPGKbpazI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-BGi7oK0gMeWi5LarZrVNtQ-1; Tue, 28 Sep 2021 07:14:42 -0400 X-MC-Unique: BGi7oK0gMeWi5LarZrVNtQ-1 Received: by mail-wr1-f71.google.com with SMTP id r15-20020adfce8f000000b0015df1098ccbso15036522wrn.4 for ; Tue, 28 Sep 2021 04:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZU+KVR0y2VTh3ZrdA51D/L+4k30fXIYJ6SUmvuXTBtU=; b=aijZJpWL2XUYS5z2zEsjnAPiJWvrUjHubQjRYH3owtpLp38qg7BntupL9rCvLSVw8u g9O/RwlRBhsbL6UWrOtOlymXj/k4DZ7RMobAS3OIlngqfBfGd7Yl5TjPHmCbVKO+W5mz cALkEqOGnJJ0QGoBr6OgLkndlVxiKGeutic2FL1G9p/xkp6Rr2RsGiQ17/Q/pjzdXmVq q0gOh8dhqF+NH4oAedElKimzPzd6klfNmR117fTpu+t3nGuNg8DnBOZsDuPmisKfIppo BZUhPqrr6a0ETnehotf2XFtT32jlEI+03dI330LJTUgChWACK2hef9oA7z7DV9TlWbLL izwA== X-Gm-Message-State: AOAM5314BBAsMlvFwKJ++QHdkBi/n3bTWsQuOMtFS43Ekud4VLUf5CpR fAe8S5edHdC0jTInF/8qE8PfbEjHy/taPdEEscUURBhP7VoVZEcfacPmp4kEFDI9gxbJNwlMdQL nj2k2uDfvaox0PAFqtU3WwU6IPR6Ja5sbuXxhVBN3bg== X-Received: by 2002:a7b:c1d6:: with SMTP id a22mr4054951wmj.146.1632827681479; Tue, 28 Sep 2021 04:14:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmyS/k9wYJiX+xvA60Ee54wMfLNQLygQJU7Coe9SlPvQKuE0bZ2nADyYTfZL/XxVTwdXQwLWEQNDjqQrl73Dg= X-Received: by 2002:a7b:c1d6:: with SMTP id a22mr4054944wmj.146.1632827681334; Tue, 28 Sep 2021 04:14:41 -0700 (PDT) MIME-Version: 1.0 References: <20210821021106.27010-1-luo.penghao@zte.com.cn> In-Reply-To: <20210821021106.27010-1-luo.penghao@zte.com.cn> From: Karol Herbst Date: Tue, 28 Sep 2021 13:14:30 +0200 Message-ID: To: CGEL Cc: Ben Skeggs , David Airlie , Daniel Vetter , dri-devel , nouveau , LKML , Luo penghao , Zeal Robot Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [Nouveau] [PATCH linux-next] drm/nouveau/mmu: drop unneeded assignment in the nvkm_uvmm_mthd_page() X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Reviewed-by: Karol Herbst On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'ret' assignments should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c:317:8:warning: > Although the value storedto 'ret' is used in the enclosing expression, > the value is never actually read from 'ret'. > > Reported-by: Zeal Robot > Signed-off-by: Luo penghao > --- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > index c43b824..d9f8e11 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > @@ -314,7 +314,7 @@ nvkm_uvmm_mthd_page(struct nvkm_uvmm *uvmm, void *argv, u32 argc) > page = uvmm->vmm->func->page; > for (nr = 0; page[nr].shift; nr++); > > - if (!(ret = nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false))) { > + if (!(nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false))) { > if ((index = args->v0.index) >= nr) > return -EINVAL; > type = page[index].type; > -- > 2.15.2 > >