From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D41DC433DB for ; Fri, 19 Mar 2021 15:18:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DD496191F for ; Fri, 19 Mar 2021 15:18:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DD496191F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 439816EA4A; Fri, 19 Mar 2021 15:18:21 +0000 (UTC) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by gabe.freedesktop.org (Postfix) with ESMTPS id 969E16EA2F for ; Fri, 19 Mar 2021 14:43:55 +0000 (UTC) Received: by mail-pj1-x1029.google.com with SMTP id a22-20020a17090aa516b02900c1215e9b33so6822039pjq.5 for ; Fri, 19 Mar 2021 07:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=86LC+1JkNbbYNnfKum5G/BlJ9HpQquJ6GZDdITyjMEY=; b=ESqHg/Y6nunNSt2A+n9NWRNhz9fMlfBI4MSa8ZUCLsFHV6hBHTbyKTb5LvtUBy3sDl tZ3TZCOfAxuslM6hVBzvZBG+WDWr6+KKfr45IXsC++3CgBLssBEmOYJPoltIUCj5Ab5r Ps5BzO93U4v5ATBIff4UXI55yoi3tueb3M2Mxsxr8AalFKT0qmZjt0ytDLMrSuh+Xjv2 nn1qSIhjlu63a0/GM1HyDQ0gsQjhbyl0d2JTYfEuiD0xDFDASfbE81sV/e6NUMEG69T/ p4rrhKaWnvLHgogq2P8lT5x0kwhxjSmRELfZbJfWCaMnzgbK6aqmocai87gZbkTlRmnh tqaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=86LC+1JkNbbYNnfKum5G/BlJ9HpQquJ6GZDdITyjMEY=; b=iyXAQZsAZEMTjdvaJ0+MOBHB2qugrYjCpgpaHTw6UNkPFOuwCJCVuLSUmj/SUJgiz2 /lzICulkvqQZu2BlzE7YhWJ0M3gHhkq+YRZxipBycqmNiT4Cj9ThXxy+oWj2746uP0IJ EJFa3RhPFpCFDEig745CLB/6/8EBhp7kO+9vK5gRseWedt6COgfg7V+tYUVKDCCZ2L6c RPw4QGnt+hxWvKIjfc/gz9KSH2cV0bVWHi2q3pICBAtNyt+8LPzsg25SYSKFZZKJ61kj ePeZRkzU6j4CAUgKsyqtAe8WfqjqJMMPaOjmlrZiExpcVjz2En4umSkSHs9hsPZitA21 pdyw== X-Gm-Message-State: AOAM532di6SUb4SaGnUXPOwNt8KTRkUBSXUtIugybKwg/5GGwQ9aanjy Y/kH/9Rudmoebn6Z4a28QVMYJXzq2AuPdAGrCDeGdw== X-Google-Smtp-Source: ABdhPJxMIHdTlGCXNCULSxlRJJagvj2AatBYPGQF37Ua2ikdmUUVJ4WnoNWSgNo0fgfSZ+4tH2iCCodydlKkCHKtvhM= X-Received: by 2002:a17:90a:be07:: with SMTP id a7mr10386254pjs.75.1616165035134; Fri, 19 Mar 2021 07:43:55 -0700 (PDT) MIME-Version: 1.0 References: <20210219215326.2227596-1-lyude@redhat.com> <20210219215326.2227596-12-lyude@redhat.com> In-Reply-To: <20210219215326.2227596-12-lyude@redhat.com> From: Robert Foss Date: Fri, 19 Mar 2021 15:43:44 +0100 Message-ID: To: Lyude Paul X-Mailman-Approved-At: Fri, 19 Mar 2021 15:18:19 +0000 Subject: Re: [Nouveau] [PATCH 11/30] drm/bridge/analogix/anx6345: Don't link encoder until after connector registration X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , nouveau@lists.freedesktop.org, dri-devel , Andrzej Hajda , Laurent Pinchart , Sam Ravnborg , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , amd-gfx@lists.freedesktop.org, Vasily Khoruzhick , Icenowy Zheng , Daniel Vetter , Jonas Karlman , intel-gfx@lists.freedesktop.org, Jani Nikula , Rodrigo Vivi , Jernej Skrabec , open list , Boris Brezillon , Torsten Duwe , Joe Perches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Another case of linking an encoder to a connector after the connector's > been registered. The proper place to do this is before connector > registration, so let's fix that. > > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > index 8e016ba7c54a..6258f16da0e8 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -556,12 +556,6 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, > drm_connector_helper_add(&anx6345->connector, > &anx6345_connector_helper_funcs); > > - err = drm_connector_register(&anx6345->connector); > - if (err) { > - DRM_ERROR("Failed to register connector: %d\n", err); > - return err; > - } > - > anx6345->connector.polled = DRM_CONNECTOR_POLL_HPD; > > err = drm_connector_attach_encoder(&anx6345->connector, > @@ -571,6 +565,12 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, > return err; > } > > + err = drm_connector_register(&anx6345->connector); > + if (err) { > + DRM_ERROR("Failed to register connector: %d\n", err); > + return err; > + } > + > return 0; > } > > -- > 2.29.2 > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau