From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3141C433DB for ; Fri, 19 Mar 2021 15:18:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0A2A61923 for ; Fri, 19 Mar 2021 15:18:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0A2A61923 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F0006EA47; Fri, 19 Mar 2021 15:18:21 +0000 (UTC) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 063376EA47 for ; Fri, 19 Mar 2021 14:38:03 +0000 (UTC) Received: by mail-pj1-x102f.google.com with SMTP id cl21-20020a17090af695b02900c61ac0f0e9so8550189pjb.1 for ; Fri, 19 Mar 2021 07:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r8t+Haw8hnnyPI1A8ckYO+AnKAwkWRp0vTVGtS6IUlo=; b=VHOSnptigraQrnHtiYP3M5TJPLgguQqQNkJ+HKd6uE/tEHIW1D2lCZYt4kluq/2Uyo +XIW78QJtL/XDkFFfwtHiv31BNMpBs+3fONQIb0wj4848a0o8Nvc/e4aIs0pkwMAblku GAA/cn8GOMk3KVKy/PN5Y9R5fA0FccSOupDMtLD/c+JgPqJU+pGEvGd/d/0DTs1kvd7J qgE7tuYaHWJfSY2oUN6QbFQCwn8sw2WEPS2upkrhFubBrn4vhwpswSpZuAJ3eAIGGZuV 9H9YKEuPCTliyuPzVKa5nnr7CvtuIstrFaSr+ovqhzSSSqV17hqiKOimHpNyb8R1EJ3b IPWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r8t+Haw8hnnyPI1A8ckYO+AnKAwkWRp0vTVGtS6IUlo=; b=YEHwu/319BGwdZrIGOYnWnitEMA8C3HzrFdjIKzoLImUw5BG7GkAflAVf63nSWtIdi q9tGoX8vI2psUXJBY1sxBYePAmcGBggrIW4Yu+Gfr2EsNQvj73Xe5+wz0FK0vVjZz9Ue vudIoGlxcTh1dbhUke9HKdluHGYBzAC6iKCki7/tkt/vCleP8THbmdIZURB0AytuvcGi XOFjU5pi/KTLnbPIGsiLAncAQ04vj11NneNYFiESGlUXcBLfzOoUJMfvxeVV4AkOB2ba xituM8dSfSMBEDLT3pBGvHrCySf073rmrahI4yAxJazi28iHAg+3pb8UPPClRZ+/3gGb MyZA== X-Gm-Message-State: AOAM532Hgfn0Iay3Cf2sJIDwR09nwT8NNU0GBLYRWWUH0SCm/4I4EOhE mPOoJku1bo96aSZzE22kSgqzeOHEDFYH8oVdQLFw/A== X-Google-Smtp-Source: ABdhPJw8c9CchTDySBs3NZLqT/TkgcU8jgQYXzTtozt8IS+78Ccw8naSaLYw4NWbogbCmYjnH85XuIvZ55HTa3abjoE= X-Received: by 2002:a17:902:7d8d:b029:e6:4061:b767 with SMTP id a13-20020a1709027d8db02900e64061b767mr14682850plm.32.1616164682659; Fri, 19 Mar 2021 07:38:02 -0700 (PDT) MIME-Version: 1.0 References: <20210219215326.2227596-1-lyude@redhat.com> <20210219215326.2227596-10-lyude@redhat.com> In-Reply-To: <20210219215326.2227596-10-lyude@redhat.com> From: Robert Foss Date: Fri, 19 Mar 2021 15:37:51 +0100 Message-ID: To: Lyude Paul X-Mailman-Approved-At: Fri, 19 Mar 2021 15:18:19 +0000 Subject: Re: [Nouveau] [PATCH 09/30] drm/bridge/analogix/anx78xx: Cleanup on error in anx78xx_bridge_attach() X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , dri-devel , Tomi Valkeinen , Neil Armstrong , David Airlie , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jonas Karlman , open list , Jani Nikula , Andrzej Hajda , Boris Brezillon , Torsten Duwe , amd-gfx@lists.freedesktop.org, Rodrigo Vivi , Daniel Vetter , Sam Ravnborg , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Just another issue I noticed while correcting usages of > drm_dp_aux_init()/drm_dp_aux_register() around the tree. If any of the > steps in anx78xx_bridge_attach() fail, we end up leaking resources. So, > let's fix that (and fix leaking a DP AUX adapter in the process) by > unrolling on errors. > > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > index 338dd8531d4b..f20558618220 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > @@ -918,7 +918,7 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, > DRM_MODE_CONNECTOR_DisplayPort); > if (err) { > DRM_ERROR("Failed to initialize connector: %d\n", err); > - return err; > + goto aux_unregister; > } > > drm_connector_helper_add(&anx78xx->connector, > @@ -930,16 +930,21 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, > bridge->encoder); > if (err) { > DRM_ERROR("Failed to link up connector to encoder: %d\n", err); > - return err; > + goto connector_cleanup; > } > > err = drm_connector_register(&anx78xx->connector); > if (err) { > DRM_ERROR("Failed to register connector: %d\n", err); > - return err; > + goto connector_cleanup; > } > > return 0; > +connector_cleanup: > + drm_connector_cleanup(&anx78xx->connector); > +aux_unregister: > + drm_dp_aux_unregister(&anx78xx->aux); > + return err; > } > > static void anx78xx_bridge_detach(struct drm_bridge *bridge) > -- > 2.29.2 > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau