From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAEC0C4338F for ; Sun, 8 Aug 2021 22:14:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E4116069E for ; Sun, 8 Aug 2021 22:14:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E4116069E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1477899E6; Sun, 8 Aug 2021 22:14:09 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2CE26EA7D; Wed, 4 Aug 2021 14:19:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A52D160F22; Wed, 4 Aug 2021 14:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628086789; bh=UhV/SQfdLBYTc9D9nBIqPDxNpUescq5pja8sCC7bUhg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GqW+Ix8bE9Xpa1PchSe10rwy9phm1XMd4MtWpBN7X3eojLy8JN6KQp9n/43TFtwni 80y7yvlPbt9DWFp/kScILAMs5dZoVWsxp5peA10/x5cfZa5vObdwIDWpX0jkQFvYaT 2MgpL23FyoaDUNhgSS2nyNLYahv0fdWor9n5QSwmUSsJLUvt7JoCZyDZ33EVspregL jDwdyiYhAt5flGpgHfIHdpgTM1ACwW61TYHC6twk5Khz9kuXn/Gp2H4ZEQb28P8yN1 FPN6Bs7CKtVW8/Ig8CE1Yf1LpEy2t7/uIkXgk1gg65UZJGajHvq52xvBjKFLdOLOay vieUvKuAW7pSw== Received: by mail-wr1-f52.google.com with SMTP id m12so2425912wru.12; Wed, 04 Aug 2021 07:19:49 -0700 (PDT) X-Gm-Message-State: AOAM532RJzvXLFVUPEin+dbxhNfM6nUr1g/OjHFLgARD5LnkXCHSCACW SrtoCDFn105dsRIs5uhm7Sz3+BU7PPTraNXtolU= X-Google-Smtp-Source: ABdhPJz4webvoPA0EIBz9Nqvki0G4OjA8pvIy/LkSY3nQYdB4tbtdSxD94XNSCYZc0/wF2Fsa+T9PiEhNiWOJgXVQLE= X-Received: by 2002:adf:e107:: with SMTP id t7mr29131713wrz.165.1628086788270; Wed, 04 Aug 2021 07:19:48 -0700 (PDT) MIME-Version: 1.0 References: <20210804141049.499767-1-kherbst@redhat.com> In-Reply-To: <20210804141049.499767-1-kherbst@redhat.com> From: Arnd Bergmann Date: Wed, 4 Aug 2021 16:19:32 +0200 X-Gmail-Original-Message-ID: Message-ID: To: Karol Herbst Cc: Linux Kernel Mailing List , Lyude Paul , Ben Skeggs , Randy Dunlap , Daniel Vetter , ML nouveau , dri-devel Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sun, 08 Aug 2021 22:14:04 +0000 Subject: Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > playing around a little bit with this, I think the original "select > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > drivers selecting and others depending on it. We could of course convert > everything over to depend, and break those cycling dependency issues with > this. > > Anyway this change on top of my initial patch is enough to make Kconfig > happy and has the advantage of not having to mess with the deps of nouveau > too much. Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE option itself 'default FB || DRM' though, to ensure that defconfigs keep working. Arnd