From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A6EC4320A for ; Sun, 8 Aug 2021 22:14:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 622CD6069E for ; Sun, 8 Aug 2021 22:14:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 622CD6069E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 196CF89A59; Sun, 8 Aug 2021 22:14:10 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 410CE894D4; Wed, 4 Aug 2021 21:10:09 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 04F0661037; Wed, 4 Aug 2021 21:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628111409; bh=AR7/8fSFLxcOU7ReweR1RJMUzQ2C6A8WBiBQgmubyxA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bstBTAnhv749RIOm/8A++1zEJoVPLjeLJya1QeLgs+5os8XLqTX8NVxd11Jh5ne0X 25RPg0sHRCshpt2JG73ht7Xyx5dhtErx1V8I9gCVolzqz237y6uQ98P1D4u3g0FnEH SnynInM+s3bEItadObYqiqLFG2NHBPRBkZeJYWhW+F5BV7++MeLDhNP+rF+X86XxpF aTbuCPg58JahZq3d68NRMmRAd9W2YnbjIVMfIoU5tbkiNR5tQSdrSe1ht84Lr9Z5cl 3geDZMkh8EWExQ4h3Kl04ZTQUyVWVA3XrMvZJNdyBdMaZiSkIusjDlYx8q+EiUfTyf 7lV0W67V/+P6g== Received: by mail-wm1-f53.google.com with SMTP id f9-20020a05600c1549b029025b0f5d8c6cso4779995wmg.4; Wed, 04 Aug 2021 14:10:08 -0700 (PDT) X-Gm-Message-State: AOAM531+r8if8hXS6xqzu66HckzJDuSlukU09vW6PnZRUjjIP/ZuT5FM Vu+Q0VQlXCJmeKWWjTc0COHhqDeJ9j21Ogvb2t8= X-Google-Smtp-Source: ABdhPJxawV1DUFGq0xf4c1YWGB9f0ICNgrFaDVK4nvjPq8GUrxtQnE1yV12ZR4xxG8yzQp9mNDGQvEuc2xvVrRg4gF8= X-Received: by 2002:a7b:ce10:: with SMTP id m16mr11140796wmc.75.1628111407639; Wed, 04 Aug 2021 14:10:07 -0700 (PDT) MIME-Version: 1.0 References: <20210804141049.499767-1-kherbst@redhat.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 4 Aug 2021 23:09:51 +0200 X-Gmail-Original-Message-ID: Message-ID: To: Karol Herbst Cc: Linux Kernel Mailing List , Lyude Paul , Ben Skeggs , Randy Dunlap , Daniel Vetter , ML nouveau , dri-devel Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sun, 08 Aug 2021 22:14:04 +0000 Subject: Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > playing around a little bit with this, I think the original "select > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > drivers selecting and others depending on it. We could of course convert > > > > everything over to depend, and break those cycling dependency issues with > > > > this. > > > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > > happy and has the advantage of not having to mess with the deps of nouveau > > > > too much. > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > keep working. > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > BACKLIGHT_CLASS_DEVICE might be disabled :( Are you sure? It should already be the case that any driver that selects FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' or 'select BACKLIGHT_CLASS_DEVICE'. If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends on', I don't see a problem with doing 'select FB_BACKLIGHT' from those. I have applied your patch to my randconfig tree and built a few dozen kernels, don't see any regressions so far, but will let it run over night. Arnd