From: Fabio Estevam <festevam@gmail.com>
To: Luiz Sampaio <sampaio.ime@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Nouveau] [PATCH 01/31] gpu: nouveau: nouveau_led: changing LED_FULL to actual value
Date: Sat, 22 Jan 2022 10:33:58 -0300 [thread overview]
Message-ID: <CAOMZO5DX-zzQGi6hWj66yHDYAHXd7yzJ6CQqtHVQHt-U4LVq8g@mail.gmail.com> (raw)
In-Reply-To: <20220121165436.30956-2-sampaio.ime@gmail.com>
Hi Luiz,
On Sat, Jan 22, 2022 at 7:44 AM Luiz Sampaio <sampaio.ime@gmail.com> wrote:
>
> The enum led_brightness, which contains the declaration of LED_OFF,
> LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
> max_brightness.
Your Signed-off-by tag is missing.
Please run ./scripts/checkpatch.pl on your patch and it helps detect
this kind of issue.
Regards,
Fabio Estevam
prev parent reply other threads:[~2022-01-23 0:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220121165436.30956-1-sampaio.ime@gmail.com>
2022-01-21 16:54 ` [Nouveau] [PATCH 01/31] gpu: nouveau: nouveau_led: changing LED_FULL to actual value Luiz Sampaio
2022-01-22 13:33 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5DX-zzQGi6hWj66yHDYAHXd7yzJ6CQqtHVQHt-U4LVq8g@mail.gmail.com \
--to=festevam@gmail.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=sampaio.ime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).