From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAA7C433E0 for ; Mon, 1 Mar 2021 23:15:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 395D160232 for ; Mon, 1 Mar 2021 23:15:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 395D160232 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC13B6E0AC; Mon, 1 Mar 2021 23:15:01 +0000 (UTC) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE21D6E0A0; Mon, 1 Mar 2021 23:14:59 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 01 Mar 2021 15:14:59 -0800 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Mar 2021 23:14:58 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.54) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 1 Mar 2021 23:14:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKXbUwTBqMNE05YNH9/Q/4drz3eC3Jg2QTgwkvxQxVYdHLSQ0+hjDTg7eRanBtDM/LE4lTQQqRNczZ5FOKpC26PSYcfu2mOE967U7f9tVCJH2ymlY315z3JdH/fMc9F9Um/Gg5APBl6w6+ONiAlEUzp9Nq6dW4+PGrV9lgBlxPqGRbNBKFgLe5XX3TN9z57qllC+9wt/70f415L6GptwEVVqpVcJQOX7IbmAQbgbF71GSs5+4XS+fJfB4Ki2unD0msf95pvcdOeCVNeuipPgSl4JrqKFk6wAl4cSN4yn3qC9bgYReev5UF2gu8+xtjE4b/ZuBX5/YKVFPL/zYtNxhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=swE9ZQpc+3LuQoZlzfLTtvT5aWiX/1n0QYmtvCFHb6I=; b=VDI7IaHWl/+nW0yTySAmgJLiAVM4N/AE0gkEdXmLcH5BCb7KyVJcRLVpMUmHM1R4Qn67WWc8XQceKszkZ0dzdFphFs7/Yug9ikWxBCacyCQU2X+rexqdbkTieThlHHVYLRhhcnriZe4Q9sv9fmBmF+2snkW7ZVfr/Ob2ipCdSkwMwCpMFYNp+WFL9A8SWbYuHi6/aQtkek1qqy3uaBQFLG1EGr0dEC86xpmcxpE9hkI/qCjOo/1rb7xX4A/rWm7+lQ4JA3BVUv1KityCH66i1kZbeor6Me0YdJlpRxPjdyMqFmx8FGVXPPGeaUc2oWjfe3mKoEZ3BwrWKjDommhJtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4344.namprd12.prod.outlook.com (2603:10b6:208:26e::11) by MN2PR12MB4799.namprd12.prod.outlook.com (2603:10b6:208:a2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20; Mon, 1 Mar 2021 23:14:57 +0000 Received: from MN2PR12MB4344.namprd12.prod.outlook.com ([fe80::6412:fe3d:f2:87db]) by MN2PR12MB4344.namprd12.prod.outlook.com ([fe80::6412:fe3d:f2:87db%8]) with mapi id 15.20.3890.028; Mon, 1 Mar 2021 23:14:57 +0000 From: Ralph Campbell To: Alistair Popple , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "bskeggs@redhat.com" , "akpm@linux-foundation.org" Thread-Topic: [PATCH v3 6/8] mm: Selftests for exclusive device memory Thread-Index: AQHXDA+10DMlRgXFfUuy1T9vHkceyqpvyHZQ Date: Mon, 1 Mar 2021 23:14:56 +0000 Message-ID: References: <20210226071832.31547-1-apopple@nvidia.com> <20210226071832.31547-7-apopple@nvidia.com> In-Reply-To: <20210226071832.31547-7-apopple@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=rcampbell@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2021-03-01T23:14:59.6412486Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=d6a14d98-c9fa-43e7-b670-24821d8db878; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [2601:646:8e80:c510:10c8:3f69:ba2e:72f8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 32e2604a-d354-4073-280b-08d8dd07d462 x-ms-traffictypediagnostic: MN2PR12MB4799: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d8f4v+YSmqhUDbYPl+kDCviPlVGAen40eAxyzPbU2tCvudkNBk0Vl+kEOARhRfCWzFUlNXTn1s5fnAOfFv8AIeVCP6PzwCv/YMrP/gj29X0WOaLYDG9V4zu7OxMIqpj/pCSww4cBJyz2FoSgXsSnkeCxFNBFy/Pt9zIe8ri2glmcFqVFW8+Kvjm4tzMpUeq9fgH7IXahT2y+jDK6PwnyCqER6mbJqtF2Yv/yJnO/76VmgEN7K429O7sjLkjJULk2p5iWX0+zGrQ+R8NS7EYm/ydEPBan8FlOtflzV/4m5GMQMEeNqGPigesomsEbB+CT8BxZgLcST1UmdNw1ir8nFcATK0x6cU+c+uZA5tBR8swbSzpnSoBRvUepD6ylLFc8QsjyTSowMILbUKK9JWZXHNG5yly2mkzSSkqUakw3IVLg8a2s0Tp6hfDQcrxtZyB2GlBJypyHmeSf15IWZTKk0+sF33XUP9n44xfCpDjvXIOFDdJ2IBml5vIXy1rt/5pUiT+CjTj4k9ZYwfhDWZMTfg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4344.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(7696005)(76116006)(66476007)(8676002)(86362001)(186003)(4326008)(66946007)(33656002)(64756008)(316002)(83380400001)(66556008)(66446008)(7416002)(110136005)(478600001)(8936002)(71200400001)(5660300002)(54906003)(55016002)(2906002)(53546011)(52536014)(9686003)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?7/f4R4ZBXgwAHx2N1cXJ9T0OS9vfdzbdYUenfettKWKdYbqaQN6cxrEkf1Yf?= =?us-ascii?Q?Twzbl6xkrB5LptWGjlWd+InbGfeDnuCfBCoU3mMMolQabtTsEbFYpQZMazmh?= =?us-ascii?Q?1xJIztTlkfYBR7pOTaYYbiifbMkrtPq2VlOy3EwvJn/V7Y98Q1AqV0LeU3Cg?= =?us-ascii?Q?f9Z01bI5lC+Ub7NKXOxMJzcq22/8fN9Qe0HaMRvXJSCPJLnTfnkkZL8ul+Ri?= =?us-ascii?Q?EP/vBLxKcc1huZ5O+j+E+iLTxY7HpykdyNrqQWh7N/mwdRfOkgx2GOT0J/Hk?= =?us-ascii?Q?BvQz34/IxYBBgItvj3tc5valstF5doydrzK/lsCEkMGeKoalLqOcvVMYY0le?= =?us-ascii?Q?qOUs9KDg/PUrXzrf0cN3pS/vN0615oCRq0/Xb9jhEZwyAfU6IwXccWNXI5e1?= =?us-ascii?Q?tbLluPGd2h5aXMRtaqx8etUDPtaIC4fYayn+JX1A5h3Is2sRsMXi33XLDyHs?= =?us-ascii?Q?OnU1xSZ6fscGgrglKQtqrm6Km0F9I7I0aflpPdWkFgrFdjaH0v+AjKrLsBFe?= =?us-ascii?Q?CCIDTi99wvxEJxu8586wtoWN4eUa1ejqh1rXROpRxED1gtrNhS0uCUY16YrB?= =?us-ascii?Q?Dt6HeXWymLxj5U7nUzAzdCyPoGWtT2MDN90hx5UwaPjqWcNKumJadH7IgwRU?= =?us-ascii?Q?U4XTqb+5IQYskrfJq9n77QUoXwPBK0rP3PNNgG29Qf7cbiJiTZI1hGEatg1P?= =?us-ascii?Q?860yxjDnB3vvU1fVTLp0Rhm8H16kqlJ+VXauJ2BfOsnumZi/zWsjbG9cwWFi?= =?us-ascii?Q?XFre+Kxu2Iaf7/nAF6sdYuQPGM9JRKQpGBq4RWvZDN5U1FOtNMrbRUtmZPQG?= =?us-ascii?Q?H2x91OAP3qZMtnZOIziV1osKQszXFDdmDmdPPWian9I6XaAI63id2z/5Kode?= =?us-ascii?Q?r85GItX7qGN2+H5I3m+0kJGCMA/1eCwt76VdgFMm3VCg3pNLKGLSRfKN9cwm?= =?us-ascii?Q?6n3Ycf0XJREqzjGXCpPT5Afzc98fjY5Xl8iCCLnK0iHxOw7b3nZeRAcboVty?= =?us-ascii?Q?YKS2CNs6PEcaQRR7Y/Lb2wRuXz8c6JVI36CtcwJhI54iRHsWqGBtfUuin1li?= =?us-ascii?Q?R6G3TkhVhPJ/2SXSoInlx8snIyWEnhqLwpxLG2JjYSbpFgLnFUnerLsLVPsq?= =?us-ascii?Q?dhfElhI/B+0Jo5tMgctkBe6HTthrPtbCQHqprL4Ra9ThnOJoIlY5FDybMVZP?= =?us-ascii?Q?9OgTGRgqbL3MKTFaGRS+9yxUPrwv92Xobf/nJ0VGSilH2k39MuYdT1uuCUUb?= =?us-ascii?Q?XMHi9lvpuVEJiqOray+hQxekPLWzQZnEcvq57abE4BQuZtpGSYPSnyMN6FO3?= =?us-ascii?Q?5NTDfaYSo2exIXLUjgF9p5bqMuxaMGUUIvEFRtUBf71VFVECO404HQ0/ENxH?= =?us-ascii?Q?2pPkLbV53lOyqEzVkUXJFFIEwYJ8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4344.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32e2604a-d354-4073-280b-08d8dd07d462 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2021 23:14:56.9153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5KT809MxI4g2ZKTssfILoaGMWkAl1xdLi5kjmqgYVCuKk5RXtkTrLaq0zRWwSDkFOhMXh+Mro8tEEGX/EdLcgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4799 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1614640499; bh=swE9ZQpc+3LuQoZlzfLTtvT5aWiX/1n0QYmtvCFHb6I=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:msip_labels:authentication-results: x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs:x-header: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=QRd/w8PZnSad4GbdfMaGRpdFJdfzmK7mQ7X7m8xtwD7//U7HOOnqC0WzOLfcq/xZ/ dccfIHIrK7xMzFvnlIVDpx9Jl1fQvGPfkQTKIgsMAtARG0GJccKxEHuYlvtYmQJ5nc JMnCRaGvuN7wk030YVtMCALliZqdLf5MQyld3+krWaebZKWBZdw/XhIqnMKSm3VEvN /ZHelcQLG4a3EvJ7uzAZCO8v3LqAHyHFmivRGvX+HrlYvLaA+vHSaY5XlNh5nR67eg weOu0rU6MAnsEIQtSdBDItahghe/5gdre9PGZfhEx2hIVyW/cS8zCj2sKlWlevGC3L wahJaiF53jRxQ== Subject: Re: [Nouveau] [PATCH v3 6/8] mm: Selftests for exclusive device memory X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "daniel@ffwll.ch" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "hch@infradead.org" , Jason Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" > From: Alistair Popple > Sent: Thursday, February 25, 2021 11:19 PM > To: linux-mm@kvack.org; nouveau@lists.freedesktop.org; > bskeggs@redhat.com; akpm@linux-foundation.org > Cc: linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; dri- > devel@lists.freedesktop.org; John Hubbard ; Ralph > Campbell ; jglisse@redhat.com; Jason Gunthorpe > ; hch@infradead.org; daniel@ffwll.ch; Alistair Popple > > Subject: [PATCH v3 6/8] mm: Selftests for exclusive device memory > > Adds some selftests for exclusive device memory. > > Signed-off-by: Alistair Popple One minor nit below, but you can add Tested-by: Ralph Campbell Reviewed-by: Ralph Campbell > +static int dmirror_exclusive(struct dmirror *dmirror, > + struct hmm_dmirror_cmd *cmd) > +{ > + unsigned long start, end, addr; > + unsigned long size = cmd->npages << PAGE_SHIFT; > + struct mm_struct *mm = dmirror->notifier.mm; > + struct page *pages[64]; > + struct dmirror_bounce bounce; > + unsigned long next; > + int ret; > + > + start = cmd->addr; > + end = start + size; > + if (end < start) > + return -EINVAL; > + > + /* Since the mm is for the mirrored process, get a reference first. */ > + if (!mmget_not_zero(mm)) > + return -EINVAL; > + > + mmap_read_lock(mm); > + for (addr = start; addr < end; addr = next) { > + int i, mapped; > + > + if (end < addr + (64 << PAGE_SHIFT)) > + next = end; > + else > + next = addr + (64 << PAGE_SHIFT); I suggest using ARRAY_SIZE(pages) instead of '64' to make the meaning clear. _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau