nouveau.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Simon Ser <contact@emersion.fr>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: nouveau <nouveau@lists.freedesktop.org>, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [Nouveau] [PATCH v2] nouveau/dispnv50: add cursor pitch check
Date: Fri, 05 Feb 2021 22:15:44 +0000	[thread overview]
Message-ID: <OwU6EvrH4NXy5d3uyiItz2FdTvtka7lhHUtqCVeKDgJ43bGec9ELDkDMGnHPJw3bemv9am9efVyQpjssB_NLMSParby2Z5kbc1QENlSL0tI=@emersion.fr> (raw)
In-Reply-To: <CAKb7Uvj3HLGMiO4uxvjmR7JCdEN_4b3K46tQeqxtCOYw2AZ1uw@mail.gmail.com>

On Friday, February 5th, 2021 at 10:50 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:

> > return head->func->curs_format(head, asyw, asyh);
>
> While you're at it, maybe give this one some love too?

Sure, although this would be a driver bug because DRM core already
checks the format. curs_format has WARN_ON when it fails.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

      reply	other threads:[~2021-02-05 22:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 21:00 [Nouveau] [PATCH v2] nouveau/dispnv50: add cursor pitch check Simon Ser
2021-02-05 21:18 ` Lyude Paul
2021-02-05 21:50 ` Ilia Mirkin
2021-02-05 22:15   ` Simon Ser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='OwU6EvrH4NXy5d3uyiItz2FdTvtka7lhHUtqCVeKDgJ43bGec9ELDkDMGnHPJw3bemv9am9efVyQpjssB_NLMSParby2Z5kbc1QENlSL0tI=@emersion.fr' \
    --to=contact@emersion.fr \
    --cc=bskeggs@redhat.com \
    --cc=imirkin@alum.mit.edu \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).