nouveau.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: Lyude Paul <lyude@redhat.com>
Cc: igt-dev@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	Ben Skeggs <bskeggs@redhat.com>,
	Martin Peres <martin.peres@mupuf.org>
Subject: Re: [Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library
Date: Fri, 19 Mar 2021 11:05:17 +0200	[thread overview]
Message-ID: <YFRpTVxr8Kso/7ky@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <3c5108990850ae8f88952c3149eaa935f7e378e7.camel@redhat.com>

On Thu, Mar 18, 2021 at 12:49:13PM -0400, Lyude Paul wrote:
> On Thu, 2021-03-18 at 11:15 +0200, Petri Latvala wrote:
> > On Thu, Mar 18, 2021 at 09:06:29AM +0200, Martin Peres wrote:
> > > On 18/03/2021 00:38, Lyude wrote:
> > > > diff --git a/include/drm-uapi/drm_fourcc.h b/include/drm-uapi/drm_fourcc.h
> > > > index a7bc058c..87c87485 100644
> > > > --- a/include/drm-uapi/drm_fourcc.h
> > > > +++ b/include/drm-uapi/drm_fourcc.h
> > > > @@ -681,7 +681,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64
> > > > modifier)
> > > >   }
> > > >   /*
> > > > - * 16Bx2 Block Linear layout, used by Tegra K1 and later
> > > > + * 16Bx2 Block Linear layout, used by desktop GPUs, and Tegra K1 and
> > > > later
> > > 
> > > Maybe remove one of the "and"s?
> > > 
> > > 16Bx2 Block Linear layout, used by desktop GPUs, and Tegra K1+
> > 
> > drm_fourcc.h is copied from the kernel, no hand-editing in IGT.
> 
> These additions are all copied from the drm_fourcc.h file in the kernel though,
> do you want me to just update the whole file instead?

It was more of a response to Martin's suggestion that would need to go
through the kernel.

As for this patch to IGT, yes please, copy the file from the kernel
as-is. As a separate commit, commit message stating which SHA in
kernel it's from.


-- 
Petri Latvala



> 
> > 
> > 
> 
> -- 
> Sincerely,
>    Lyude Paul (she/her)
>    Software Engineer at Red Hat
>    
> Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
> asked me a question, are waiting for a review/merge on a patch, etc. and I
> haven't responded in a while, please feel free to send me another email to check
> on my status. I don't bite!
> 
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  reply	other threads:[~2021-03-19  9:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 22:38 [Nouveau] [PATCH i-g-t] lib: Introduce the igt_nouveau library Lyude
2021-03-18  7:06 ` [Nouveau] [igt-dev] " Martin Peres
2021-03-18  9:15   ` Petri Latvala
2021-03-18 16:49     ` Lyude Paul
2021-03-19  9:05       ` Petri Latvala [this message]
2021-03-24 22:32         ` Lyude Paul
2021-03-18  9:17 ` Petri Latvala
2021-03-24 22:24   ` Lyude Paul
2021-03-25  8:35     ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFRpTVxr8Kso/7ky@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=bskeggs@redhat.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    --cc=martin.peres@mupuf.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).