From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AAAC433F5 for ; Sat, 18 Sep 2021 06:25:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71CE560F43 for ; Sat, 18 Sep 2021 06:25:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71CE560F43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=u92.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14FCE6F3E2; Sat, 18 Sep 2021 06:25:40 +0000 (UTC) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 423AF6E0C4; Fri, 17 Sep 2021 22:41:45 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 5AF182B0092E; Fri, 17 Sep 2021 18:41:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 17 Sep 2021 18:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u92.eu; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=pbWS3mhStDO/vyfrIneJKdNr84W uoAjNdq5ZOc04Za4=; b=R8fDp2teNWIc+9ikwj5txBoV5lhAWSQU6/iSCmma86O opfL0jI4+of4PDSWIjSyki8qMKiVE3OHQOz1LCNTIkgxzQfM1Y6aDZtAOIJtNljb 1drMJ2FRRPRbzhA0NmDn2z9VkFqeokVQjsB7ewCJX0CAQjTeAaS4By7Nj362ryTx Q0X4l3uHnJXTYdQOGzjKEcyGsgp7syMPBOQz4Z9Np3uf5PEuqpws29hmXSUkXOeB rca2RsPnCVEI61CjgsqmQH9MLaH+F91MCixiNiz5taxERa9qLMhZiNpOjoTAfbwU m8A0Q5JqNrdGRA4q3/bD8o/aCeqOfwsXlb59GcaJAhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=pbWS3m hStDO/vyfrIneJKdNr84WuoAjNdq5ZOc04Za4=; b=JXFFoS+mDQKTy8VX0SIVLE 4fLTLmt5IRKDFNVntUlBenpRUmKW6gIBK4g6T+7nKj/XXmyYPHcGWrH0ylQ8HSi8 haVVIIn+wc2nGuKqkDTe2qkgDYfMh0/Yilo7llo4Vlt+nwZLYPorywKI/asRWNKB TT5U77VXBf/+rFNMRyz0GMta3In3hvCh1OGAtOlqcB9PauMVDDB7UhP455/zxIJX WxpRXWvGZOGfqPoMkMtuAMv6heOIi5AqRFZ1adiBatXdXS232F3/RvLWCl0mCsz6 7djJoWpEPD3tFYE6a6eqljZtrsPV4gv1lHhl85RNd3tZvnwvMX0Al+hbLhbR8msQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehjedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttdejnecuhfhrohhmpefhvghrnhgr nhguohcutfgrmhhoshcuoehgrhgvvghnfhhoohesuhelvddrvghuqeenucggtffrrghtth gvrhhnpedvjeeifeelhfetiefhhfdthfefkefhhfeutdetvdfgvefgveefheffgfekjeef heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrh gvvghnfhhoohesuhelvddrvghu X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Sep 2021 18:41:38 -0400 (EDT) Date: Sat, 18 Sep 2021 00:41:35 +0200 From: Fernando Ramos To: Sean Paul Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org Message-ID: References: <20210916211552.33490-1-greenfoo@u92.eu> <20210916211552.33490-12-greenfoo@u92.eu> <20210917154250.GL2515@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210917154250.GL2515@art_vandelay> X-Mailman-Approved-At: Sat, 18 Sep 2021 06:25:39 +0000 Subject: Re: [Nouveau] [PATCH 11/15] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" > > int i, out_width; > > + int ret; > > Please put ret with i & out_width Done! > > - drm_modeset_unlock_all(crtc->dev); > > + DRM_MODESET_LOCK_ALL_END(crtc->dev, ctx, ret); > > > > return 0; > > Return ret here Done!