From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Sean Paul <seanpaul@chromium.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] [PATCH v3 5/5] drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs()
Date: Tue, 19 Oct 2021 21:15:02 +0300 [thread overview]
Message-ID: <YW8LJrCi41BkterA@intel.com> (raw)
In-Reply-To: <20211006024018.320394-6-lyude@redhat.com>
On Tue, Oct 05, 2021 at 10:40:18PM -0400, Lyude Paul wrote:
> Hooray! We've managed to hit enough bugs upstream that I've been able to
> come up with a pretty solid explanation for how backlight controls are
> actually supposed to be detected and used these days. As well, having the
> rest of the PWM bits in VESA's backlight interface implemented seems to
> have fixed all of the problematic brightness controls laptop panels that
> we've hit so far.
>
> So, let's actually document this instead of just calling the laptop panels
> liars. As well, I would like to formally apologize to all of the laptop
> panels I called liars. I'm sorry laptop panels, hopefully you can all
> forgive me and we can move past this~
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> .../drm/i915/display/intel_dp_aux_backlight.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 91daf9ab50e8..04a52d6a74ed 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -455,11 +455,17 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *connector)
> }
>
> /*
> - * A lot of eDP panels in the wild will report supporting both the
> - * Intel proprietary backlight control interface, and the VESA
> - * backlight control interface. Many of these panels are liars though,
> - * and will only work with the Intel interface. So, always probe for
> - * that first.
> + * Since Intel has their own backlight control interface, the majority of machines out there
> + * using DPCD backlight controls with Intel GPUs will be using this interface as opposed to
> + * the VESA interface. However, other GPUs (such as Nvidia's) will always use the VESA
> + * interface. This means that there's quite a number of panels out there that will advertise
> + * support for both interfaces, primarily systems with Intel/Nvidia hybrid GPU setups.
> + *
> + * There's a catch to this though: on many panels that advertise support for both
> + * interfaces, the VESA backlight interface will stop working once we've programmed the
> + * panel with Intel's OUI - which is also required for us to be able to detect Intel's
> + * backlight interface at all. This means that the only sensible way for us to detect both
> + * interfaces is to probe for Intel's first, and VESA's second.
> */
You know a lot more about this than I do.
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> if (try_intel_interface && intel_dp_aux_supports_hdr_backlight(connector)) {
> drm_dbg_kms(dev, "Using Intel proprietary eDP backlight controls\n");
> --
> 2.31.1
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2021-10-19 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 2:40 [Nouveau] [PATCH v3 0/5] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers Lyude Paul
2021-10-06 2:40 ` [Nouveau] [PATCH v3 1/5] drm/i915: Add support for panels with VESA backlights with PWM enable/disable Lyude Paul
2021-10-19 18:09 ` Ville Syrjälä
2021-10-20 21:30 ` Lyude Paul
2021-10-06 2:40 ` [Nouveau] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness Lyude Paul
2021-10-06 16:30 ` Karol Herbst
2021-10-06 20:14 ` Lyude Paul
2021-10-06 2:40 ` [Nouveau] [PATCH v3 3/5] drm/dp: Disable unsupported features in DP_EDP_BACKLIGHT_MODE_SET_REGISTER Lyude Paul
2021-10-06 2:40 ` [Nouveau] [PATCH v3 4/5] drm/dp, drm/i915: Add support for VESA backlights using PWM for brightness control Lyude Paul
2021-10-12 20:45 ` Doug Anderson
2021-10-06 2:40 ` [Nouveau] [PATCH v3 5/5] drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs() Lyude Paul
2021-10-19 18:15 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW8LJrCi41BkterA@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).