From: Claudio Suarez <cssk@net-c.es>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-tegra@vger.kernel.org, intel-gfx@lists.freedesktop.org,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan Xinhui" <Xinhui.Pan@amd.com>,
"Emma Anholt" <emma@anholt.net>,
"Maxime Ripard" <mripard@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Rob Clark" <robdclark@gmail.com>, "Sean Paul" <sean@poorly.run>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
"Chen-Yu Tsai" <wens@csie.org>,
"Sandy Huang" <hjc@rock-chips.com>,
heiko@sntech.de, "Neil Armstrong" <narmstrong@baylibre.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH v2 01/13] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info
Date: Wed, 20 Oct 2021 00:40:20 +0200 [thread overview]
Message-ID: <YW9JVOUrG0Ubnvtf@gineta.localdomain> (raw)
In-Reply-To: <YW8P3GPGezUhoBcW@intel.com>
On Tue, Oct 19, 2021 at 09:35:08PM +0300, Ville Syrjälä wrote:
> On Sat, Oct 16, 2021 at 08:42:14PM +0200, Claudio Suarez wrote:
> > According to the documentation, drm_add_edid_modes
> > "... Also fills out the &drm_display_info structure and ELD in @connector
> > with any information which can be derived from the edid."
> >
> > drm_add_edid_modes accepts a struct edid *edid parameter which may have a
> > value or may be null. When it is not null, connector->display_info and
> > connector->eld are updated according to the edid. When edid=NULL, only
> > connector->eld is reset. Reset connector->display_info to be consistent
> > and accurate.
> >
> > Signed-off-by: Claudio Suarez <cssk@net-c.es>
> > ---
> > drivers/gpu/drm/drm_edid.c | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index 6325877c5fd6..c643db17782c 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -5356,14 +5356,13 @@ int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid)
> > int num_modes = 0;
> > u32 quirks;
> >
> > - if (edid == NULL) {
> > - clear_eld(connector);
> > - return 0;
> > - }
> > if (!drm_edid_is_valid(edid)) {
>
> OK, so drm_edid_is_valid() will happily accept NULL and considers
> it invalid. You may want to mention that explicitly in the commit
> message.
Thank you for your comments, I appreciate :)
I'm sending new mails with the new commit messages.
> > + /* edid == NULL or invalid here */
> > clear_eld(connector);
> > - drm_warn(connector->dev, "%s: EDID invalid.\n",
> > - connector->name);
> > + drm_reset_display_info(connector);
> > + if (edid)
> > + drm_warn(connector->dev, "%s: EDID invalid.\n",
> > + connector->name);
>
> Could you respin this to use the standard [CONNECTOR:%d:%s] form
> while at it? Or I guess a patch to mass convert the whole drm_edid.c
> might be another option.
Good point.
I like the idea of a new patch. I'll start working on it. I can change
this drm_warn here to avoid merge conflicts.
> Patch looks good.
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks!
BR
Claudio Suarez.
next prev parent reply other threads:[~2021-10-19 22:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 18:42 [Nouveau] [PATCH v2 00/13] replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 01/13] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info Claudio Suarez
2021-10-19 18:35 ` Ville Syrjälä
2021-10-19 22:40 ` Claudio Suarez [this message]
2021-10-19 22:49 ` [Nouveau] [PATCH v3 " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 02/13] drm/vc4: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 03/13] drm/radeon: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 04/13] drm/tegra: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 05/13] drm/gma500: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 06/13] drm/exynos: " Claudio Suarez
2021-10-26 22:28 ` Inki Dae
2021-11-02 12:34 ` Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 07/13] drm/msm: " Claudio Suarez
2021-11-25 13:26 ` Dmitry Baryshkov
2021-10-16 18:42 ` [Nouveau] [PATCH v2 08/13] drm/sun4i: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 09/13] drm/sti: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 10/13] drm/rockchip: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 11/13] drm/bridge: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 12/13] drm/nouveau: " Claudio Suarez
2021-10-16 18:42 ` [Nouveau] [PATCH v2 13/13] drm/i915: " Claudio Suarez
2021-10-19 18:37 ` Ville Syrjälä
2021-10-19 22:51 ` [Nouveau] [PATCH v3 " Claudio Suarez
2021-10-21 13:49 ` Ville Syrjälä
2021-10-22 10:25 ` Claudio Suarez
2021-10-22 12:01 ` Ville Syrjälä
2021-10-22 12:22 ` [Nouveau] [Intel-gfx] " Ville Syrjälä
2021-10-24 22:17 ` Claudio Suarez
2021-11-02 12:56 ` [Nouveau] " Claudio Suarez
2021-11-02 13:00 ` [Nouveau] [PATCH v4 " Claudio Suarez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW9JVOUrG0Ubnvtf@gineta.localdomain \
--to=cssk@net-c.es \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=nouveau@lists.freedesktop.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=thierry.reding@gmail.com \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).