From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79EB9C433F5 for ; Fri, 14 Jan 2022 16:10:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B185010EDE5; Fri, 14 Jan 2022 16:10:22 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42D8310EDE3; Fri, 14 Jan 2022 16:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642176621; x=1673712621; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VuM59CA5P02uN+pfSy6KjURQRN07fGepNkmo2Y2bY9w=; b=WWLUQUApoAcqf7M4rU1p8A64Wm77RvSQ/1aw9fgzV7YDwF0iRC8joKj/ EuU5dMFaeAAuViN4kOTtYGdsZWF4PQhsLqjreBIxkcaMQjoxPIip0rPuR 52M5dCHsHPyyPvrpOUgQNVdDcb6rgt5PHCj/1FyZcpg8kpq4vpQVr1Du9 OEFJcvGPbAbntRkcnRjs8n28xDLnjDL1Zv9j1cbxPw7hlasEnRMTO5EXV 8Bf1OWFF2jsOPeV65kehOlLu9Kn0OpoFU2m0WZbhbkBxvoOHBkBs28LTZ 6zKhbETzwF8DRRhXzfETxfQjYOh7MktbHx51TsPueKSE3SYZd2DG3qIR3 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="243087267" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="243087267" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 08:10:20 -0800 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="577316857" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 08:10:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1n8P6O-00AiC0-2o; Fri, 14 Jan 2022 18:06:56 +0200 Date: Fri, 14 Jan 2022 18:06:55 +0200 From: Andy Shevchenko To: Simon Ser Message-ID: References: <20220114101753.24996-1-etom@igel.co.jp> <20220114101753.24996-3-etom@igel.co.jp> <7eljcd3F4aWL2jjBRwr3DISmyt0XPWFIH1_kebFGqZTJXLZRx0bm_8c8yaIuEuH8rS0MaJhU6SY1y-fc6U_zCLaKgoLM124nZpr0H91nSjw=@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: Re: [Nouveau] [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Michel =?iso-8859-1?Q?D=E4nzer?= , Daniel Stone , Lee Jones , Tomohito Esaki , Rob Clark , Takanari Hayama , amd-gfx@lists.freedesktop.org, Ben Skeggs , Petr Mladek , Sakari Ailus , Maarten Lankhorst , Abhinav Kumar , Alex Deucher , Sean Paul , Maxime Ripard , Daniel Vetter , Evan Quan , Mark Yacoub , Qingqing Zhuo , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Bas Nieuwenhuizen , Dmitry Baryshkov , Damian Hobson-Garcia , Christian =?iso-8859-1?Q?K=F6nig?= , Laurent Pinchart Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Fri, Jan 14, 2022 at 03:42:54PM +0000, Simon Ser wrote: > On Friday, January 14th, 2022 at 16:17, Andy Shevchenko wrote: > > > On Fri, Jan 14, 2022 at 03:07:21PM +0000, Simon Ser wrote: > > > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko wrote: > > > > > > > Why not enum? > > > > > > There is no enum for DRM format modifiers. > > > > I'm not sure how this prevents to use enum in the code instead of const u64. > > Any specific reason for that? > > I'm not sure how one would use an enum as the array item type, when there is no > defined enum type. > > Moreover, all the rest of DRM uses uint64 for modifiers. Ah, I see now. This is an array that filled by predefined values. Thanks for explanation. -- With Best Regards, Andy Shevchenko