Nouveau Archive on lore.kernel.org
 help / color / Atom feed
From: James Jones <jajones@nvidia.com>
To: <lyude@redhat.com>, Ilia Mirkin <imirkin@alum.mit.edu>,
	Alex Riesen <alexander.riesen@cetitec.com>
Cc: nouveau <nouveau@lists.freedesktop.org>, Simon Ser <contact@emersion.fr>
Subject: Re: [Nouveau] [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Wed, 3 Mar 2021 09:05:09 -0800
Message-ID: <b33cdcd4-25f9-c748-61f2-cb07918ee94f@nvidia.com> (raw)
In-Reply-To: <2dd41d05f6fff86cce7f5a08063de1509e2e3a42.camel@redhat.com>

On 3/3/21 8:51 AM, Lyude Paul wrote:
> On Wed, 2021-03-03 at 08:12 -0500, Ilia Mirkin wrote:
>> On Wed, Mar 3, 2021 at 7:41 AM Alex Riesen <alexander.riesen@cetitec.com>
>> wrote:
>>>
>>> Ilia Mirkin, Sat, Feb 27, 2021 22:26:57 +0100:
>>>> Can you try Alex's patch to modetest and confirm that you see issues
>>>> with modetest? If so, can you (and maybe Alex as well) try an older
>>>> kernel (I'm on 5.6) and see if modetest behaves well there. [The patch
>>>> in question was to expose 256x256 as the 'preferred' size, but support
>>>> for the larger cursors has been around for a while.] Alex - if you
>>>> have time, same question to you.
>>>
>>> Sorry that it took so long. I retestet with the same kernel as Uwe did
>>> (5.4.101) and my results are the same: modetest with 64 and 128 cursors
>>> looks
>>> good, 256 broken. Didn't test with X this time (this being my main office
>>> machine), but can do later if required.
>>
>> Thanks for confirming! No need to test X - that will work fine, since
>> we were reporting the smaller cursors on that kernel.
>>
>> So I think we have definitive evidence that at least all Kepler
>> doesn't do 256x256 (and it's not just some bug in the display macro
>> rework that got introduced). And unless I'm blind and don't see the
>> corruption, Pascal seems fine. Question remains for Maxwell1/2 GPUs.
>> Unless someone has immediate plans to test on those, I'd recommend
>> bumping the minimum for 256x256 being reported to Pascal, and doing
>> 128x128 for Kepler / Maxwell.
> 
> I'm fairly sure this will actually work fine on maxwell, I think Kepler is the
> only one I'm aware of so far that has issues with this. I've got one of each gen
> from kepler 1 up to ampere, so I'll try to find some today to test the cards
> I've got and see where the support cutoff for this is and then submit a patch
> for the time being.
> 
> It's also really strange to me that this would be present in the display classes
> yet not be supported on the GPU, since there definitely aren't any capabilities
> for this. I'll also send an email to Andy and see if he might know what's going
> on here.

FWIW, it's not my area, but I've been following, and forwarded this 
thread around internally.  We discussed a bit, and Kepler definitely 
supports 256x256 cursors. One suggestion was if you aren't already, try 
using 4k pages. The rest was a bit beyond me, so I'll let Andy and Lyude 
discuss further if needed.

Thanks,
-James

>> Simon, Lyude -- thoughts?
>>
>> Cheers,
>>
>>    -ilia
>>
> 
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  reply index

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19  1:54 [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Lyude Paul
     [not found] ` <20210119015415.2511028-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-01-19  1:54   ` [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Lyude Paul
     [not found]     ` <20210119015415.2511028-2-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-01-19 10:22       ` Simon Ser
2021-02-23 14:15     ` [Nouveau] " Alex Riesen
2021-02-23 14:56       ` Ilia Mirkin
2021-02-23 15:36         ` Alex Riesen
2021-02-23 15:46           ` Ilia Mirkin
2021-02-23 15:51             ` Alex Riesen
2021-02-23 16:22               ` Alex Riesen
2021-02-23 18:13                 ` Ilia Mirkin
2021-02-24  9:08                   ` Alex Riesen
2021-02-24 15:10                     ` Ilia Mirkin
2021-02-24 16:35                       ` Alex Riesen
2021-02-24 16:48                         ` Ilia Mirkin
2021-02-24 16:53                           ` Alex Riesen
2021-02-24 16:57                             ` Ilia Mirkin
2021-02-24 17:02                               ` Alex Riesen
2021-02-24 17:47                                 ` Ilia Mirkin
2021-02-27 12:28                                   ` Uwe Sauter
2021-02-27 21:26                                     ` Ilia Mirkin
2021-02-28 15:10                                       ` Uwe Sauter
2021-02-28 17:02                                         ` Ilia Mirkin
2021-02-28 17:59                                           ` Uwe Sauter
2021-02-28 19:10                                             ` Ilia Mirkin
2021-02-28 19:24                                               ` Uwe Sauter
2021-02-28 20:38                                                 ` Ilia Mirkin
2021-03-03 12:41                                       ` Alex Riesen
2021-03-03 13:12                                         ` Ilia Mirkin
2021-03-03 13:25                                           ` Uwe Sauter
2021-03-03 13:33                                             ` Ilia Mirkin
2021-03-03 17:02                                               ` Uwe Sauter
2021-03-03 17:11                                                 ` Lyude Paul
2021-03-03 16:51                                           ` Lyude Paul
2021-03-03 17:05                                             ` James Jones [this message]
2021-01-19  1:54   ` [PATCH 3/3] drm/nouveau/kms/nve4-nv138: Fix > 64x64 cursors Lyude Paul
2021-01-19 10:18   ` [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Simon Ser
2021-01-19 15:50   ` Ville Syrjälä
2021-01-19 15:52   ` James Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b33cdcd4-25f9-c748-61f2-cb07918ee94f@nvidia.com \
    --to=jajones@nvidia.com \
    --cc=alexander.riesen@cetitec.com \
    --cc=contact@emersion.fr \
    --cc=imirkin@alum.mit.edu \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Nouveau Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/nouveau/0 nouveau/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 nouveau nouveau/ https://lore.kernel.org/nouveau \
		nouveau@lists.freedesktop.org
	public-inbox-index nouveau

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.nouveau


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git