From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>, Dongli Zhang <dongli.zhang@oracle.com>
Cc: ulf.hansson@linaro.org, airlied@linux.ie,
benh@kernel.crashing.org, joonas.lahtinen@linux.intel.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, paulus@samba.org, hpa@zytor.com,
mingo@kernel.org, m.szyprowski@samsung.com,
sstabellini@kernel.org, adrian.hunter@intel.com,
mpe@ellerman.id.au, x86@kernel.org, joe.jin@oracle.com,
peterz@infradead.org, mingo@redhat.com, bskeggs@redhat.com,
linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org,
matthew.auld@intel.com, thomas.lendacky@amd.com,
konrad.wilk@oracle.com, intel-gfx@lists.freedesktop.org,
jani.nikula@linux.intel.com, bp@alien8.de,
rodrigo.vivi@intel.com, nouveau@lists.freedesktop.org,
Claire Chang <tientzu@chromium.org>,
boris.ostrovsky@oracle.com, chris@chris-wilson.co.uk,
jgross@suse.com, tsbogend@alpha.franken.de,
linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org,
iommu@lists.linux-foundation.org, tglx@linutronix.de,
bauerman@linux.ibm.com, daniel@ffwll.ch,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
rppt@kernel.org
Subject: Re: [Nouveau] [PATCH RFC v1 2/6] swiotlb: convert variables to arrays
Date: Thu, 4 Feb 2021 11:49:23 +0000 [thread overview]
Message-ID: <b46ddefe-d91a-fa6a-0e0d-cf1edc343c2e@arm.com> (raw)
In-Reply-To: <20210204072947.GA29812@lst.de>
On 2021-02-04 07:29, Christoph Hellwig wrote:
> On Wed, Feb 03, 2021 at 03:37:05PM -0800, Dongli Zhang wrote:
>> This patch converts several swiotlb related variables to arrays, in
>> order to maintain stat/status for different swiotlb buffers. Here are
>> variables involved:
>>
>> - io_tlb_start and io_tlb_end
>> - io_tlb_nslabs and io_tlb_used
>> - io_tlb_list
>> - io_tlb_index
>> - max_segment
>> - io_tlb_orig_addr
>> - no_iotlb_memory
>>
>> There is no functional change and this is to prepare to enable 64-bit
>> swiotlb.
>
> Claire Chang (on Cc) already posted a patch like this a month ago,
> which looks much better because it actually uses a struct instead
> of all the random variables.
Indeed, I skimmed the cover letter and immediately thought that this
whole thing is just the restricted DMA pool concept[1] again, only from
a slightly different angle.
Robin.
[1]
https://lore.kernel.org/linux-iommu/20210106034124.30560-1-tientzu@chromium.org/
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2021-02-04 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 23:37 [Nouveau] [PATCH RFC v1 0/6] swiotlb: 64-bit DMA buffer Dongli Zhang
2021-02-03 23:37 ` [Nouveau] [PATCH RFC v1 1/6] swiotlb: define new enumerated type Dongli Zhang
2021-02-03 23:37 ` [Nouveau] [PATCH RFC v1 2/6] swiotlb: convert variables to arrays Dongli Zhang
2021-02-04 7:29 ` Christoph Hellwig
2021-02-04 11:49 ` Robin Murphy [this message]
2021-02-04 19:31 ` Konrad Rzeszutek Wilk
2021-02-03 23:37 ` [Nouveau] [PATCH RFC v1 3/6] swiotlb: introduce swiotlb_get_type() to calculate swiotlb buffer type Dongli Zhang
2021-02-03 23:37 ` [Nouveau] [PATCH RFC v1 4/6] swiotlb: enable 64-bit swiotlb Dongli Zhang
2021-02-03 23:37 ` [Nouveau] [PATCH RFC v1 5/6] xen-swiotlb: convert variables to arrays Dongli Zhang
2021-02-04 8:40 ` Christoph Hellwig
2021-02-07 15:56 ` Christoph Hellwig
2021-02-19 20:32 ` Konrad Rzeszutek Wilk
2021-02-19 23:59 ` Boris Ostrovsky
2021-02-23 1:22 ` Stefano Stabellini
2021-02-03 23:37 ` [Nouveau] [PATCH RFC v1 6/6] xen-swiotlb: enable 64-bit xen-swiotlb Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b46ddefe-d91a-fa6a-0e0d-cf1edc343c2e@arm.com \
--to=robin.murphy@arm.com \
--cc=adrian.hunter@intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=bauerman@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dongli.zhang@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgross@suse.com \
--cc=joe.jin@oracle.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=matthew.auld@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nouveau@lists.freedesktop.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rodrigo.vivi@intel.com \
--cc=rppt@kernel.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tientzu@chromium.org \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).