From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
amd-gfx@lists.freedesktop.org,
"VMware Graphics" <linux-graphics-maintainer@vmware.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Neal Gompa" <ngompa13@gmail.com>,
"Dave Airlie" <airlied@redhat.com>,
"Chia-I Wu" <olvaffe@gmail.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Michel Dänzer" <michel@daenzer.net>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
nouveau@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
spice-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
intel-gfx@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Zack Rusin" <zackr@vmware.com>
Subject: Re: [Nouveau] [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic
Date: Wed, 3 Nov 2021 16:00:47 +0100 [thread overview]
Message-ID: <dbdbaf95-8625-aec9-4446-d39db77b23f2@redhat.com> (raw)
In-Reply-To: <e02d23be-1a1c-570d-e76f-dbea76b6dd55@suse.de>
Hello Thomas,
On 11/3/21 14:01, Thomas Zimmermann wrote:
[snip]
>>
>>
>> Javier Martinez Canillas (5):
>> drm/i915: Fix comment about modeset parameters
>> drm: Move nomodeset kernel parameter handler to the DRM subsystem
>> drm: Rename vgacon_text_force() function to drm_modeset_disabled()
>> drm: Add a drm_drv_enabled() helper function
>> drm: Use drm_drv_enabled() instead of drm_modeset_disabled()
>
> There's too much churn here IMHO. Please merge patches 2+3 and 4+5. And
> I'd put patch (4+5) first, so you have the drivers out of the way. After
> that patch (2+3) should only modify drm_drv_enabled().
>
Sure, I'm happy with less patches.
Thanks for your feedback.
> Best regards
> Thomas
>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
prev parent reply other threads:[~2021-11-05 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 12:28 [Nouveau] [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-03 12:28 ` [Nouveau] [RESEND PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem Javier Martinez Canillas
2021-11-03 12:41 ` Thomas Zimmermann
2021-11-03 13:06 ` Javier Martinez Canillas
2021-11-03 12:56 ` Jani Nikula
2021-11-03 13:09 ` Javier Martinez Canillas
2021-11-03 12:28 ` [Nouveau] [RESEND PATCH 3/5] drm: Rename vgacon_text_force() function to drm_modeset_disabled() Javier Martinez Canillas
2021-11-03 12:57 ` Thomas Zimmermann
2021-11-03 14:28 ` Javier Martinez Canillas
2021-11-03 13:01 ` [Nouveau] [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic Thomas Zimmermann
2021-11-03 15:00 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbdbaf95-8625-aec9-4446-d39db77b23f2@redhat.com \
--to=javierm@redhat.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=gurchetansingh@chromium.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kraxel@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michel@daenzer.net \
--cc=mripard@kernel.org \
--cc=ngompa13@gmail.com \
--cc=nouveau@lists.freedesktop.org \
--cc=olvaffe@gmail.com \
--cc=pbrobinson@gmail.com \
--cc=pekka.paalanen@collabora.com \
--cc=rodrigo.vivi@intel.com \
--cc=spice-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).