From: Frank Li <frank.li@nxp.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "allenbh@gmail.com" <allenbh@gmail.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"dave.jiang@intel.com" <dave.jiang@intel.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"kw@linux.com" <kw@linux.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"ntb@lists.linux.dev" <ntb@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix indentation of the struct epf_ntb_ctrl
Date: Tue, 1 Nov 2022 16:08:00 +0000 [thread overview]
Message-ID: <HE1PR0401MB2331A8A3546988B5BBBE85B888369@HE1PR0401MB2331.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20221101115621.GF54667@thinkpad>
> -----Original Message-----
> From: Manivannan Sadhasivam <mani@kernel.org>
> Sent: Tuesday, November 1, 2022 6:56 AM
> To: Frank Li <frank.li@nxp.com>
> Cc: allenbh@gmail.com; bhelgaas@google.com; dave.jiang@intel.com;
> helgaas@kernel.org; imx@lists.linux.dev; jdmason@kudzu.us;
> kw@linux.com; linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org;
> lpieralisi@kernel.org; ntb@lists.linux.dev
> Subject: [EXT] Re: [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix
> indentation of the struct epf_ntb_ctrl
>
> Caution: EXT Email
>
> On Fri, Oct 28, 2022 at 11:56:58AM -0400, Frank Li wrote:
> > From: Frank Li <frank.li@nxp.com>
> >
> > Indentation of the struct epf_ntb_ctrl align with other struct
> >
>
> "Align the indentation of struct epf_ntb_ctrl with other structs in the driver"
>
> > Signed-off-by: Frank Li <frank.li@nxp.com>
> > ---
> > drivers/pci/endpoint/functions/pci-epf-vntb.c | 28 +++++++++----------
> > 1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > index c0115bcb3b5e..1863006cc36c 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > @@ -99,20 +99,20 @@ enum epf_ntb_bar {
> > * NTB Driver NTB Driver
> > */
> > struct epf_ntb_ctrl {
> > - u32 command;
> > - u32 argument;
> > - u16 command_status;
> > - u16 link_status;
> > - u32 topology;
> > - u64 addr;
> > - u64 size;
> > - u32 num_mws;
> > - u32 reserved;
> > - u32 spad_offset;
> > - u32 spad_count;
> > - u32 db_entry_size;
> > - u32 db_data[MAX_DB_COUNT];
> > - u32 db_offset[MAX_DB_COUNT];
> > + u32 command;
> > + u32 argument;
> > + u16 command_status;
> > + u16 link_status;
> > + u32 topology;
> > + u64 addr;
> > + u64 size;
> > + u32 num_mws;
> > + u32 reserved;
> > + u32 spad_offset;
> > + u32 spad_count;
> > + u32 db_entry_size;
> > + u32 db_data[MAX_DB_COUNT];
> > + u32 db_offset[MAX_DB_COUNT];
>
> General question: Don't we need to take care of endianess here?
[Frank Li] you are right. But it is out of scope of this patch.
We can add it later.
>
> Thanks,
> Mani
>
> > } __packed;
> >
> > struct epf_ntb {
> > --
> > 2.34.1
> >
>
> --
> மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-11-01 16:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 15:56 [PATCH v14 0/7] pci-epf-vntb clean up Frank Li
2022-10-28 15:56 ` [PATCH v14 1/7] PCI: endpoint: pci-epf-vntb: Clean up kernel_doc warning Frank Li
2022-11-01 11:49 ` Manivannan Sadhasivam
2022-10-28 15:56 ` [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix indentation of the struct epf_ntb_ctrl Frank Li
2022-11-01 11:56 ` Manivannan Sadhasivam
2022-11-01 16:08 ` Frank Li [this message]
2022-10-28 15:56 ` [PATCH v14 3/7] PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr at err path Frank Li
2022-11-01 11:06 ` kernel test robot
2022-11-01 11:57 ` Manivannan Sadhasivam
2022-10-28 15:57 ` [PATCH v14 4/7] PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy Frank Li
2022-11-01 11:58 ` Manivannan Sadhasivam
2022-10-28 15:57 ` [PATCH v14 5/7] PCI: endpoint: pci-epf-vntb: replace hardcode 4 with sizeof(u32) Frank Li
2022-11-01 12:00 ` Manivannan Sadhasivam
2022-10-28 15:57 ` [PATCH v14 6/7] PCI: endpoint: pci-epf-vntb: fix sparse build warning at epf_db Frank Li
2022-11-01 12:24 ` Manivannan Sadhasivam
2022-11-01 12:47 ` kernel test robot
2022-10-28 15:57 ` [PATCH v14 7/7] PCI: endpoint: pci-epf-vntb: fix sparse build warning at ntb->reg Frank Li
2022-11-01 12:27 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0401MB2331A8A3546988B5BBBE85B888369@HE1PR0401MB2331.eurprd04.prod.outlook.com \
--to=frank.li@nxp.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=helgaas@kernel.org \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).