From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/5] fs/ntfs3: Pass flags to ntfs_set_ea in ntfs_set_acl_ex
Date: Wed, 22 Sep 2021 20:59:04 +0300 [thread overview]
Message-ID: <20210922175904.s5rxwhabnfopjbve@kari-VirtualBox> (raw)
In-Reply-To: <fd75b417-f5a0-d0f2-c2d3-35d465e41334@paragon-software.com>
On Wed, Sep 22, 2021 at 07:19:19PM +0300, Konstantin Komarov wrote:
> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Please tell why we need to pass flags to ntfs_set_ea(). Commit message
is for why we do something. It does not have to have example have any
info what we did. Code will tell that.
> ---
> fs/ntfs3/xattr.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
> index 3795943efc8e..70f2f9eb6b1e 100644
> --- a/fs/ntfs3/xattr.c
> +++ b/fs/ntfs3/xattr.c
> @@ -549,6 +549,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
> size_t size, name_len;
> void *value = NULL;
> int err = 0;
> + int flags;
>
> if (S_ISLNK(inode->i_mode))
> return -EOPNOTSUPP;
> @@ -591,20 +592,24 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
> }
>
> if (!acl) {
> + /* Remove xattr if it can be presented via mode. */
> size = 0;
> value = NULL;
> + flags = XATTR_REPLACE;
> } else {
> size = posix_acl_xattr_size(acl->a_count);
> value = kmalloc(size, GFP_NOFS);
> if (!value)
> return -ENOMEM;
> -
> err = posix_acl_to_xattr(mnt_userns, acl, value, size);
> if (err < 0)
> goto out;
> + flags = 0;
> }
>
> - err = ntfs_set_ea(inode, name, name_len, value, size, 0, locked);
> + err = ntfs_set_ea(inode, name, name_len, value, size, flags, locked);
> + if (err == -ENODATA && !size)
> + err = 0; /* Removing non existed xattr. */
> if (!err)
> set_cached_acl(inode, type, acl);
>
> --
> 2.33.0
>
>
>
next prev parent reply other threads:[~2021-09-22 17:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 16:15 [PATCH 0/5] Refactor locking in inode_operations Konstantin Komarov
2021-09-22 16:17 ` [PATCH 1/5] fs/ntfs3: Move ni_lock_dir and ni_unlock into ntfs_create_inode Konstantin Komarov
2021-09-22 18:12 ` Kari Argillander
2021-09-22 16:18 ` [PATCH 2/5] fs/ntfs3: Refactor ntfs_get_acl_ex for better readability Konstantin Komarov
2021-09-22 17:47 ` Kari Argillander
2021-09-22 16:19 ` [PATCH 3/5] fs/ntfs3: Pass flags to ntfs_set_ea in ntfs_set_acl_ex Konstantin Komarov
2021-09-22 17:59 ` Kari Argillander [this message]
2021-09-22 16:20 ` [PATCH 4/5] fs/ntfs3: Change posix_acl_equiv_mode to posix_acl_update_mode Konstantin Komarov
2021-09-22 18:23 ` Kari Argillander
2021-09-22 16:20 ` [PATCH 5/5] fs/ntfs3: Refactoring lock in ntfs_init_acl Konstantin Komarov
2021-09-22 18:41 ` Kari Argillander
2021-09-22 18:51 ` [PATCH 0/5] Refactor locking in inode_operations Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922175904.s5rxwhabnfopjbve@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).