From: Shigeru Yoshida <syoshida@redhat.com>
To: almaz.alexandrovich@paragon-software.com
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
syoshida@redhat.com,
syzbot+9d67170b20e8f94351c8@syzkaller.appspotmail.com
Subject: Re: [PATCH] fs/ntfs3: Fix memory leak on ntfs_fill_super() error path
Date: Thu, 08 Sep 2022 01:01:32 +0900 (JST) [thread overview]
Message-ID: <20220908.010132.1804908388305469820.syoshida@redhat.com> (raw)
In-Reply-To: <20220823103205.1380235-1-syoshida@redhat.com>
ping?
On Tue, 23 Aug 2022 19:32:05 +0900, Shigeru Yoshida wrote:
> syzbot reported kmemleak as below:
>
> BUG: memory leak
> unreferenced object 0xffff8880122f1540 (size 32):
> comm "a.out", pid 6664, jiffies 4294939771 (age 25.500s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 ed ff ed ff 00 00 00 00 ................
> backtrace:
> [<ffffffff81b16052>] ntfs_init_fs_context+0x22/0x1c0
> [<ffffffff8164aaa7>] alloc_fs_context+0x217/0x430
> [<ffffffff81626dd4>] path_mount+0x704/0x1080
> [<ffffffff81627e7c>] __x64_sys_mount+0x18c/0x1d0
> [<ffffffff84593e14>] do_syscall_64+0x34/0xb0
> [<ffffffff84600087>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
>
> This patch fixes this issue by freeing mount options on error path of
> ntfs_fill_super().
>
> Reported-by: syzbot+9d67170b20e8f94351c8@syzkaller.appspotmail.com
> Signed-off-by: Shigeru Yoshida <syoshida@redhat.com>
> ---
> fs/ntfs3/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 47012c9bf505..c0e45f170701 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -1281,6 +1281,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
> * Free resources here.
> * ntfs_fs_free will be called with fc->s_fs_info = NULL
> */
> + put_mount_options(sbi->options);
> put_ntfs(sbi);
> sb->s_fs_info = NULL;
>
> --
> 2.37.2
>
next prev parent reply other threads:[~2022-09-07 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 10:32 [PATCH] fs/ntfs3: Fix memory leak on ntfs_fill_super() error path Shigeru Yoshida
2022-09-07 16:01 ` Shigeru Yoshida [this message]
2022-09-30 15:51 ` Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908.010132.1804908388305469820.syoshida@redhat.com \
--to=syoshida@redhat.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=syzbot+9d67170b20e8f94351c8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).