From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Kari Argillander <kari.argillander@gmail.com>,
"ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>,
Christoph Hellwig <hch@lst.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: RE: [PATCH v4 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings
Date: Fri, 27 Aug 2021 17:12:28 +0000 [thread overview]
Message-ID: <373c644eff6d4e2b8137acc0ca6faf7f@paragon-software.com> (raw)
In-Reply-To: <20210824183708.1008538-1-kari.argillander@gmail.com>
> From: Kari Argillander <kari.argillander@gmail.com>
> Sent: Tuesday, August 24, 2021 9:37 PM
> To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>; ntfs3@lists.linux.dev; Christoph Hellwig <hch@lst.de>
> Cc: Kari Argillander <kari.argillander@gmail.com>; linux-kernel@vger.kernel.org; Joe Perches <joe@perches.com>
> Subject: [PATCH v4 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings
>
> In ntfs3 driver there is allocation made like this ntfs_malloc().
> Patch 2/3 will converter these to kernel ones like kmalloc(). After I
> did this then checkpatch raise warnings about array allocations so I
> fix these in patch 3/3.
>
> I also notice when I made patch that there is broken utf8 char so I
> wanted first fix that because it raised some warning in my editor and
> did not want to "break" patch 2/3. And because we are editing comment
> then make whole comment block clean. So patch 1/3 address that. I did
> try to apply this and it seem to work without issues.
>
> v2:
> - Add patch 1/3 because I found broken utf8 char in source file
> - Add another patch 3/3 which will fix allocation warnings
> - Rewrite some of commit message from first patch
> v3:
> - Patch series didn't have X/X numbers
> - Cover letter didn't have fs/ntfs3 in it
> - One kmalloc was converted to kcalloc insted of kmalloc_array
> Thanks Joe Perches
> v4:
> - Wrap whole comment block in patch 1/1 max 80 char. And restyle.
> Thanks Christoph Hellwig for noting this
> - Add Reviewed-by: from Christoph Hellwig to patch 2 and 3
>
> Kari Argillander (3):
> fs/ntfs3: Restyle comment block in ni_parse_reparse()
> fs/ntfs3: Do not use driver own alloc wrappers
> fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmalloc
>
> fs/ntfs3/attrib.c | 6 +-
> fs/ntfs3/attrlist.c | 10 +--
> fs/ntfs3/bitmap.c | 8 +--
> fs/ntfs3/debug.h | 7 --
> fs/ntfs3/file.c | 4 +-
> fs/ntfs3/frecord.c | 42 ++++++-----
> fs/ntfs3/fslog.c | 172 ++++++++++++++++++++++----------------------
> fs/ntfs3/fsntfs.c | 8 +--
> fs/ntfs3/index.c | 54 +++++++-------
> fs/ntfs3/inode.c | 10 +--
> fs/ntfs3/lznt.c | 4 +-
> fs/ntfs3/ntfs_fs.h | 18 ++---
> fs/ntfs3/record.c | 8 +--
> fs/ntfs3/run.c | 8 +--
> fs/ntfs3/super.c | 20 +++---
> fs/ntfs3/xattr.c | 18 ++---
> 16 files changed, 197 insertions(+), 200 deletions(-)
>
> --
> 2.25.1
Hi Kari, Christoph and Joe! Thanks for your contribution, applied these patch series to our tree.
Best regards,
Konstantin
prev parent reply other threads:[~2021-08-27 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 18:37 [PATCH v4 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings Kari Argillander
2021-08-24 18:37 ` [PATCH v4 1/3] fs/ntfs3: Restyle comment block in ni_parse_reparse() Kari Argillander
2021-08-25 6:33 ` Christoph Hellwig
2021-08-24 18:37 ` [PATCH v4 2/3] fs/ntfs3: Do not use driver own alloc wrappers Kari Argillander
2021-08-24 18:37 ` [PATCH v4 3/3] fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmalloc Kari Argillander
2021-08-27 17:12 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=373c644eff6d4e2b8137acc0ca6faf7f@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=kari.argillander@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).