From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Kari Argillander <kari.argillander@gmail.com>, <ntfs3@lists.linux.dev>
Cc: linux-kernel@vger.kernel.org, "Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v2] fs/ntfs3: Remove deprecated mount options nls
Date: Thu, 23 Sep 2021 19:12:52 +0300 [thread overview]
Message-ID: <a3dad3d1-6216-c289-d0fe-ffb36950481c@paragon-software.com> (raw)
In-Reply-To: <20210921171901.49176-1-kari.argillander@gmail.com>
On 21.09.2021 20:19, Kari Argillander wrote:
> Some discussion has been spoken that this deprecated mount options
> should be removed before 5.15 lands. This driver is not never seen day
> light so it was decided that nls mount option has to be removed. We have
> always possibility to add this if needed.
>
> One possible need is example if current ntfs driver will be taken out of
> kernel and ntfs3 needs to support mount options what it has.
>
> Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
> ---
> Patch is compile and checkpatch tested.
>
> v2:
> -Do not delete {}
> ---
> fs/ntfs3/super.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 6a535b144ff9..800897777eb0 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -246,10 +246,6 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = {
> fsparam_flag_no("prealloc", Opt_prealloc),
> fsparam_flag_no("acsrules", Opt_noacsrules),
> fsparam_string("iocharset", Opt_iocharset),
> -
> - __fsparam(fs_param_is_string,
> - "nls", Opt_iocharset,
> - fs_param_deprecated, NULL),
> {}
> };
>
>
> base-commit: 6354467245ff8dd04b54e39790f2ee4d21d5419e
>
Applied, thanks!
prev parent reply other threads:[~2021-09-23 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 17:19 [PATCH v2] fs/ntfs3: Remove deprecated mount options nls Kari Argillander
2021-09-23 16:12 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3dad3d1-6216-c289-d0fe-ffb36950481c@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=kari.argillander@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).