From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Mohammad Rasim <mohammad.rasim96@gmail.com>,
Kari Argillander <kari.argillander@gmail.com>
Cc: <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fs/ntfs3: Check for NULL if ATTR_EA_INFO is incorrect
Date: Wed, 6 Oct 2021 17:47:03 +0300 [thread overview]
Message-ID: <bcbb8ddc-3ddf-4a91-6e92-d5cee2722bad@paragon-software.com> (raw)
In-Reply-To: <c892016c-3e50-739b-38d2-010f02d52019@gmail.com>
On 04.10.2021 23:39, Mohammad Rasim wrote:
>
> On 10/3/21 20:50, Kari Argillander wrote:
>> On Wed, Sep 29, 2021 at 07:35:43PM +0300, Konstantin Komarov wrote:
>>> This can be reason for reported panic.
>>> Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation")
>> I see that you have include this to devel branch but you did not send V2
>> [1]. I also included Mohammad Rasim to this thread. Maybe they can test
>> this patch. Rasim can you test [2] if your problem will be fixed with
>> this tree. Or just test this patch if you prefer that way.
>>
>> [1]: github.com/Paragon-Software-Group/linux-ntfs3/commit/35afb70dcfe4eb445060dd955e5b67d962869ce5
>> [2]: github.com/Paragon-Software-Group/linux-ntfs3/tree/devel
>
> Yeah unfortunately the problem still exist, moving the buildroot git tree from my nvme ext4 partition to my wd ntfs partition still causes the panic.
>
> Note that i used the master branch if that matters but it contains the same commit
>
>
> Regards
>
Is panic the same as old one?
BUG: kernel NULL pointer dereference, address: 000000000000000e
RIP: 0010:ni_write_inode+0xe6b/0xed0 [ntfs3]
etc.
>>> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
>>> ---
>>> fs/ntfs3/frecord.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
>>> index 9a53f809576d..007602badd90 100644
>>> --- a/fs/ntfs3/frecord.c
>>> +++ b/fs/ntfs3/frecord.c
>>> @@ -3080,7 +3080,9 @@ static bool ni_update_parent(struct ntfs_inode *ni, struct NTFS_DUP_INFO *dup,
>>> const struct EA_INFO *info;
>>> info = resident_data_ex(attr, sizeof(struct EA_INFO));
>>> - dup->ea_size = info->size_pack;
>>> + /* If ATTR_EA_INFO exists 'info' can't be NULL. */
>>> + if (info)
>>> + dup->ea_size = info->size_pack;
>>> }
>>> }
>>> --
>>> 2.33.0
>>>
next prev parent reply other threads:[~2021-10-06 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 16:35 [PATCH] fs/ntfs3: Check for NULL if ATTR_EA_INFO is incorrect Konstantin Komarov
2021-09-29 17:44 ` Kari Argillander
2021-10-03 17:50 ` Kari Argillander
2021-10-04 20:39 ` Mohammad Rasim
2021-10-06 14:47 ` Konstantin Komarov [this message]
2021-10-06 17:42 ` Mohammad Rasim
2021-10-11 16:55 ` Konstantin Komarov
2021-10-11 20:56 ` Mohammad Rasim
2021-10-06 14:51 ` Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcbb8ddc-3ddf-4a91-6e92-d5cee2722bad@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=kari.argillander@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rasim96@gmail.com \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).