From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Aleksandr Nogikh <nogikh@google.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Andrew Morton <akpm@linux-foundation.org>,
Namjae Jeon <linkinjeon@kernel.org>,
Shigeru Yoshida <syoshida@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+1631f09646bc214d2e76@syzkaller.appspotmail.com>,
"'Aleksandr Nogikh' via syzkaller-bugs"
<syzkaller-bugs@googlegroups.com>,
ntfs3@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/ntfs3: fix negative shift size in true_sectors_per_clst()
Date: Fri, 23 Sep 2022 23:35:43 +0900 [thread overview]
Message-ID: <ea7c00c1-07d7-c23e-80f0-0693016e9731@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <CANp29Y7fSsjqKbFiMZDG_w-ERigQOk_6Zw3L9rw5erpP3rRU0g@mail.gmail.com>
On 2022/09/23 20:58, Aleksandr Nogikh wrote:
> We do have plans to start inspecting LKML messages for the patches
> that mention syzbot-reported bugs. It will be possible then to display
> them all on the bug page and somehow mark bugs with a PATCH sent on
> the list.
I interpret it as an attempt to automatically show "Patch proposed" state.
But since not all patches have Reported-by: tag, and/or a proposed patch
with Reported-by: tag might be withdrawn via review, that state should be
also manually changeable.
> And then syzbot should just display all such received comments on the
> bug's web page, right?
Whether "all comments" or "last comment" needs some decision. It might be a few words
indicating culprit subsystem (probably "last" should overwrite), it might be memo
describing how far debugging went (probably "all" is helpful), it might be some
URL where discussions/patches are (probably "all" is helpful), it might be trying to
show or hide "Patch proposed" state (probably "last" should overwrite).
By the way, a possible improvement on "Patch testing requests:" table.
Although the "Patch" link showing diff output after applying proposed patch is OK,
I'd like to also see a link to original "#syz test:" mail, for the intent of diff
(which would be in patch description part if it was a formal patch) is dropped from
diff output in the "Patch" link.
For example, https://syzkaller.appspot.com/bug?extid=9ca7a12fd736d93e0232 was forgotten
for 1000 days after 7 patch testing requests. I can't easily find the intent of each diff
(e.g. just debug printk() or proper fix). It seems the last one was about to formal submit,
but I can't find why it is not yet applied.
next prev parent reply other threads:[~2022-09-23 14:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 8:16 [syzbot] UBSAN: shift-out-of-bounds in ntfs_fill_super syzbot
2022-04-21 8:37 ` syzbot
2022-04-21 12:29 ` syzbot
2022-09-20 15:59 ` [PATCH] fs/ntfs3: fix negative shift size in true_sectors_per_clst() Tetsuo Handa
2022-09-23 0:38 ` Randy Dunlap
2022-09-23 0:47 ` Joe Perches
2022-09-23 1:14 ` Randy Dunlap
2022-09-23 9:59 ` Dan Carpenter
2022-09-23 1:25 ` Tetsuo Handa
2022-09-23 11:58 ` Aleksandr Nogikh
2022-09-23 14:35 ` Tetsuo Handa [this message]
2022-09-24 11:58 ` Aleksandr Nogikh
2022-09-24 12:03 ` Aleksandr Nogikh
2022-09-23 11:58 ` Konstantin Komarov
2022-09-23 16:07 ` Randy Dunlap
2022-09-30 16:34 ` Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7c00c1-07d7-c23e-80f0-0693016e9731@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=dvyukov@google.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nogikh@google.com \
--cc=ntfs3@lists.linux.dev \
--cc=rdunlap@infradead.org \
--cc=syoshida@redhat.com \
--cc=syzbot+1631f09646bc214d2e76@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).