From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <ntfs3@lists.linux.dev>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] fs/ntfs3: uninitialized variable in ntfs_set_acl_ex()
Date: Wed, 10 Aug 2022 19:18:00 +0300 [thread overview]
Message-ID: <fba5803f-ec98-1b63-1518-803567a5d5ef@paragon-software.com> (raw)
In-Reply-To: <YvDKoXqt5GuZNzzN@kili>
On 8/8/22 11:34, Dan Carpenter wrote:
> The goto out calls kfree(value) on an uninitialized pointer. Just
> return directly as the other error paths do.
>
> Fixes: 460bbf2990b3 ("fs/ntfs3: Do not change mode if ntfs_set_ea failed")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/ntfs3/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
> index 02f6a933ee79..5bdff12a1232 100644
> --- a/fs/ntfs3/xattr.c
> +++ b/fs/ntfs3/xattr.c
> @@ -568,7 +568,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
> err = posix_acl_update_mode(mnt_userns, inode, &mode,
> &acl);
> if (err)
> - goto out;
> + return err;
> }
> name = XATTR_NAME_POSIX_ACL_ACCESS;
> name_len = sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1;
Thanks for patch, applied!
prev parent reply other threads:[~2022-08-10 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 8:34 [PATCH] fs/ntfs3: uninitialized variable in ntfs_set_acl_ex() Dan Carpenter
2022-08-10 16:18 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba5803f-ec98-1b63-1518-803567a5d5ef@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).