From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: "'Verma, Vishal L'" <vishal.l.verma@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: RE: [PATCH v2] ndctl, filter: refacor util_<obj>_filter() to support multiple space-seperated arguments
Date: Thu, 19 Apr 2018 02:10:05 +0000 [thread overview]
Message-ID: <0DEDF3B159719A448A49EF0E7B11E3222764E26B@g01jpexmbkw01> (raw)
In-Reply-To: <1524067583.6010.7.camel@intel.com>
> From: Verma, Vishal L [mailto:vishal.l.verma@intel.com]
> Sent: Thursday, April 19, 2018 1:06 AM
> To: Williams, Dan J <dan.j.williams@intel.com>; Qi, Fuli/斉 福利
> <qi.fuli@jp.fujitsu.com>
> Cc: linux-nvdimm@lists.01.org
> Subject: Re: [PATCH v2] ndctl, filter: refacor util_<obj>_filter() to support multiple
> space-seperated arguments
>
> On Wed, 2018-04-18 at 07:31 -0700, Dan Williams wrote:
> > On Tue, Apr 17, 2018 at 11:32 PM, QI Fuli <qi.fuli@jp.fujitsu.com> wrote:
> > > This patch refactors util_<obj>_filter to support multiple space-
> > > seperated arguments. Currently, only one <object> can be filtered by
> > > <object>'s name in util_<obj>_filter(). As a result, when users want
> > > to moniotr multiple dimms, they have to run multiple monitor
> > > processes. This feature teachs the
> > > util_dimm_filter() that the "ident" argument maybe a space-seperatd
> > > string which includes multiple dimm_names. Therefore the monitor can
> > > filter multiple dimms in one process.
> > >
> > > Signed-off-by: QI Fuli <qi.fuli@jp.fujitsu.com>
> > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>
> I'll fix up the tags like so:
>
> Based-on-a-patch-by: Dan Williams <dan.j.williams@intel.com>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: QI Fuli <qi.fuli@jp.fujitsu.com>
>
>
> Thanks,
> -Vishal
>
> > >
> > > Change log since v1:
> > > - Removing OPT_STRING_LIST from parse-option
> >
> > Looks good:
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Thank you very much.
- Qi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-04-19 2:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 6:32 [PATCH v2] ndctl, filter: refacor util_<obj>_filter() to support multiple space-seperated arguments QI Fuli
2018-04-18 14:31 ` Dan Williams
2018-04-18 16:06 ` Verma, Vishal L
2018-04-19 2:10 ` Qi, Fuli [this message]
2018-04-25 2:39 ` Qi, Fuli
2018-04-25 7:32 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DEDF3B159719A448A49EF0E7B11E3222764E26B@g01jpexmbkw01 \
--to=qi.fuli@jp.fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).