From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: 'Dan Williams' <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: RE: [PATCH 1/2] ndctl, util: add OPT_STRING_LIST to parse_option
Date: Thu, 19 Apr 2018 02:18:54 +0000 [thread overview]
Message-ID: <0DEDF3B159719A448A49EF0E7B11E3222764E285@g01jpexmbkw01> (raw)
In-Reply-To: <CAPcyv4j4mirvPkfjiM94P+X+tNpw5LuEUt-7brcOSk8tzd_vcQ@mail.gmail.com>
> -----Original Message-----
> From: Dan Williams [mailto:dan.j.williams@intel.com]
> Sent: Thursday, April 19, 2018 11:10 AM
> To: Qi, Fuli/斉 福利 <qi.fuli@jp.fujitsu.com>
> Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
> Subject: Re: [PATCH 1/2] ndctl, util: add OPT_STRING_LIST to parse_option
>
> On Wed, Apr 18, 2018 at 7:06 PM, Qi, Fuli <qi.fuli@jp.fujitsu.com> wrote:
> >> > Thank you very much, I made a v2 patch by referring to your sample patch.
> >> >
> >> > Going back to the OPT_STRING_LIST, I think it is necessary for ndctl.
> >> > Because the other options in monitor like --dimm-event, --bus-event
> >> > also need to support multiple space-separated arguments, these options
> >> > should be made as a string_list.
> >>
> >> Ok, yes, lets bring in string_list for that case.
> >>
> >
> > Could you merge the OPT_STRING_LIST first?
>
> Oh, I was assuming when you said string_list that you would redo the
> patch to bring in the struct string_list implementation from git, and
> not use the strtok() approach. I'd like to not diverge from that
> implementation.
>
Ok, I see. I will redo the patch to bring in the struct string_list from git.
Thank you.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-04-19 2:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 6:38 [PATCH 0/2] ndctl: change ndctl to support multiple arguments per option QI Fuli
2018-04-17 6:38 ` [PATCH 1/2] ndctl, util: add OPT_STRING_LIST to parse_option QI Fuli
2018-04-17 14:56 ` Dan Williams
2018-04-17 15:29 ` Qi, Fuli
2018-04-17 16:32 ` Dan Williams
2018-04-18 10:09 ` Qi, Fuli
2018-04-18 14:30 ` Dan Williams
2018-04-19 2:06 ` Qi, Fuli
2018-04-19 2:09 ` Dan Williams
2018-04-19 2:18 ` Qi, Fuli [this message]
2018-04-17 6:38 ` [PATCH 2/2] ndctl, list: change -b -d -r -n options to support multiple arguments QI Fuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DEDF3B159719A448A49EF0E7B11E3222764E285@g01jpexmbkw01 \
--to=qi.fuli@jp.fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).