From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: 'Vishal Verma' <vishal.l.verma@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: RE: [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent
Date: Tue, 31 Jul 2018 02:05:50 +0000 [thread overview]
Message-ID: <0DEDF3B159719A448A49EF0E7B11E3223DA9B7DB@g01jpexmbkw24> (raw)
In-Reply-To: <20180730193522.30458-1-vishal.l.verma@intel.com>
> -----Original Message-----
> From: Vishal Verma [mailto:vishal.l.verma@intel.com]
> Sent: Tuesday, July 31, 2018 4:35 AM
> To: linux-nvdimm@lists.01.org
> Cc: Vishal Verma <vishal.l.verma@intel.com>; Qi, Fuli/斉 福利
> <qi.fuli@jp.fujitsu.com>
> Subject: [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in
> test_filter_dimmevent
>
> Change the inject-smart field from -s to -m when testing the dimm-media-temperature
> event. The -s seems to have been a copy-paste error.
>
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> test/monitor.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/monitor.sh b/test/monitor.sh index 1bbfd14..29d4ea1 100755
> --- a/test/monitor.sh
> +++ b/test/monitor.sh
> @@ -152,7 +152,7 @@ test_filter_dimmevent()
> inject_value=$($NDCTL list -H -d $monitor_dimms | jq
> -r .[]."health"."temperature_threshold")
> inject_value=$((inject_value + 1))
> start_monitor "-d $monitor_dimms -D dimm-media-temperature"
> - inject_smart "-s $inject_value"
> + inject_smart "-m $inject_value"
> check_result "$monitor_dimms"
> stop_monitor
> }
Hi Vishal,
Yes, this is a copy-paste error and I am sorry for this.
Thank you very much.
QI
> --
> 2.14.4
>
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-07-31 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 19:35 [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent Vishal Verma
2018-07-31 2:05 ` Qi, Fuli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DEDF3B159719A448A49EF0E7B11E3223DA9B7DB@g01jpexmbkw24 \
--to=qi.fuli@jp.fujitsu.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).