* [ndctl PATCH] ndctl, test: add UUID_LIBS for list_smart_dimm
@ 2018-08-20 20:21 Vishal Verma
2018-08-21 2:17 ` Qi, Fuli
0 siblings, 1 reply; 2+ messages in thread
From: Vishal Verma @ 2018-08-20 20:21 UTC (permalink / raw)
To: linux-nvdimm
Some environments automatically include the missing library dependency,
and others need it to be explicitly included.
Link: https://github.com/pmem/ndctl/issues/66
Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
Fixes: d1941474111a ("ndctl, test: add a new unit test for monitor")
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
test/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/Makefile.am b/test/Makefile.am
index c224eb7..50bb2e4 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -162,4 +162,5 @@ list_smart_dimm_SOURCES = \
list_smart_dimm_LDADD = \
$(LIBNDCTL_LIB) \
$(JSON_LIBS) \
+ $(UUID_LIBS) \
../libutil.a
--
2.14.4
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [ndctl PATCH] ndctl, test: add UUID_LIBS for list_smart_dimm
2018-08-20 20:21 [ndctl PATCH] ndctl, test: add UUID_LIBS for list_smart_dimm Vishal Verma
@ 2018-08-21 2:17 ` Qi, Fuli
0 siblings, 0 replies; 2+ messages in thread
From: Qi, Fuli @ 2018-08-21 2:17 UTC (permalink / raw)
To: 'Vishal Verma', linux-nvdimm
> -----Original Message-----
> From: Vishal Verma [mailto:vishal.l.verma@intel.com]
> Sent: Tuesday, August 21, 2018 5:21 AM
> To: linux-nvdimm@lists.01.org
> Cc: Vishal Verma <vishal.l.verma@intel.com>; Qi, Fuli/斉 福利
> <qi.fuli@jp.fujitsu.com>
> Subject: [ndctl PATCH] ndctl, test: add UUID_LIBS for list_smart_dimm
>
> Some environments automatically include the missing library dependency, and others
> need it to be explicitly included.
>
> Link: https://github.com/pmem/ndctl/issues/66
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Fixes: d1941474111a ("ndctl, test: add a new unit test for monitor")
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> test/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/Makefile.am b/test/Makefile.am index c224eb7..50bb2e4 100644
> --- a/test/Makefile.am
> +++ b/test/Makefile.am
> @@ -162,4 +162,5 @@ list_smart_dimm_SOURCES = \ list_smart_dimm_LDADD = \
> $(LIBNDCTL_LIB) \
> $(JSON_LIBS) \
> + $(UUID_LIBS) \
> ../libutil.a
Looks good to me.
Reviewed-by: QI Fuli <qi.fuli@jp.fujitsu.com>
Thank you very much.
Qi
> --
> 2.14.4
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-21 2:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-20 20:21 [ndctl PATCH] ndctl, test: add UUID_LIBS for list_smart_dimm Vishal Verma
2018-08-21 2:17 ` Qi, Fuli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).