nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: "'Verma, Vishal L'" <vishal.l.verma@intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"Gotou, Yasunori" <y-goto@jp.fujitsu.com>
Cc: "andreas@canonical.com" <andreas@canonical.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: RE: [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message
Date: Fri, 5 Oct 2018 06:15:20 +0000	[thread overview]
Message-ID: <0DEDF3B159719A448A49EF0E7B11E3223DAF910F@g01jpexmbkw24> (raw)
In-Reply-To: <4adb62046776c34d28172a94aa95157774e41644.camel@intel.com>

> > > >
> > >
> > > Sounds good to me.
> >
> > In my original idea, I just wanted to log the "daemon started" message.
> > After thinking more about it, I agree that the message is not at "error" level.
> > However, considering this message will be helpful for some users like system
> operators,
> > how about changing this message level to "info" and meanwhile changing the
> default log level to "LOG_INFO" as following?
> >
> > diff --git a/ndctl/monitor.c b/ndctl/monitor.c
> > index d29e378..10866b6 100644
> > --- a/ndctl/monitor.c
> > +++ b/ndctl/monitor.c
> > @@ -628,7 +628,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
> >         if (monitor.verbose)
> >                 ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_DEBUG);
> >         else
> > -               ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_NOTICE);
> > +               ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_INFO);
> >
> >         rc = read_config_file((struct ndctl_ctx *)ctx, &monitor, &param);
> >         if (rc)
> > @@ -657,7 +657,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
> >                 if (!monitor.log || strncmp(monitor.log, "./", 2) == 0)
> >                         ndctl_set_log_fn((struct ndctl_ctx *)ctx, log_syslog);
> >                 if (daemon(0, 0) != 0) {
> > -                       err((struct ndctl_ctx *)ctx, "daemon start failed\n");
> > +                       info((struct ndctl_ctx *)ctx, "daemon start failed\n");
> >                         goto out;
> >                 }
> >                 err((struct ndctl_ctx *)ctx, "ndctl monitor daemon started\n");
> 
> Yes, this looks good to me. Will you send a proper patch for this, and I
> can replace my patch with yours.
> 
> Thanks,
> 	-Vishal
> 

Ok, I will send a patch.

> >
> > Thank you very much,
> > QI Fuli
> > > _______________________________________________
> > > Linux-nvdimm mailing list
> > > Linux-nvdimm@lists.01.org
> > > https://lists.01.org/mailman/listinfo/linux-nvdimm
> >
> >
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

      parent reply	other threads:[~2018-10-05  6:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  0:00 Vishal Verma
2018-10-05  0:00 ` [ndctl PATCH 2/2] ndctl, monitor: in daemon mode, exit successfully if no DIMMs are found Vishal Verma
2018-10-05  0:05   ` Williams, Dan J
2018-10-05  5:15   ` Qi, Fuli
2018-10-05  0:04 ` [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message Williams, Dan J
2018-10-05  4:08 ` Yasunori Goto
2018-10-05  4:23   ` Dan Williams
2018-10-05  4:59     ` Qi, Fuli
     [not found]       ` <4adb62046776c34d28172a94aa95157774e41644.camel@intel.com>
2018-10-05  6:15         ` Qi, Fuli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0DEDF3B159719A448A49EF0E7B11E3223DAF910F@g01jpexmbkw24 \
    --to=qi.fuli@jp.fujitsu.com \
    --cc=andreas@canonical.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    --cc=y-goto@jp.fujitsu.com \
    --subject='RE: [ndctl PATCH 1/2] ndctl, monitor: fix the severity of the "daemon started" message' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).