From: Pankaj Gupta <pagupta@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>, Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, KVM list <kvm@vger.kernel.org>,
Qemu Developers <qemu-devel@nongnu.org>,
linux-nvdimm <linux-nvdimm@ml01.01.org>,
Linux MM <linux-mm@kvack.org>, Jan Kara <jack@suse.cz>,
Stefan Hajnoczi <stefanha@redhat.com>,
Haozhong Zhang <haozhong.zhang@intel.com>,
Nitesh Narayan Lal <nilal@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ross Zwisler <ross.zwisler@intel.com>,
David Hildenbrand <david@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>
Subject: Re: [RFC 2/2] KVM: add virtio-pmem driver
Date: Thu, 12 Oct 2017 18:52:45 -0400 (EDT) [thread overview]
Message-ID: <1111804283.19946669.1507848765955.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1507847249.21121.207.camel@redhat.com>
> > > wrote:
> > > >
> > > > > > This patch adds virtio-pmem driver for KVM guest.
> > > > > > Guest reads the persistent memory range information
> > > > > > over virtio bus from Qemu and reserves the range
> > > > > > as persistent memory. Guest also allocates a block
> > > > > > device corresponding to the pmem range which later
> > > > > > can be accessed with DAX compatible file systems.
> > > > > > Idea is to use the virtio channel between guest and
> > > > > > host to perform the block device flush for guest pmem
> > > > > > DAX device.
> > > > > >
> > > > > > There is work to do including DAX file system support
> > > > > > and other advanced features.
> > > > > >
> > > > > > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> > > > > > ---
> > > > > > drivers/virtio/Kconfig | 10 ++
> > > > > > drivers/virtio/Makefile | 1 +
> > > > > > drivers/virtio/virtio_pmem.c | 322
> > > > > > +++++++++++++++++++++++++++++++++++++++
> > > > > > include/uapi/linux/virtio_pmem.h | 55 +++++++
> > > > > > 4 files changed, 388 insertions(+)
> > > > > > create mode 100644 drivers/virtio/virtio_pmem.c
> > > > > > create mode 100644 include/uapi/linux/virtio_pmem.h
> > > > > >
> > > > > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > > > > > index cff773f15b7e..0192c4bda54b 100644
> > > > > > --- a/drivers/virtio/Kconfig
> > > > > > +++ b/drivers/virtio/Kconfig
> > > > > > @@ -38,6 +38,16 @@ config VIRTIO_PCI_LEGACY
> > > > > >
> > > > > > If unsure, say Y.
> > > > > >
> > > > > > +config VIRTIO_PMEM
> > > > > > + tristate "Virtio pmem driver"
> > > > > > + depends on VIRTIO
> > > > > > + ---help---
> > > > > > + This driver adds persistent memory range within a
> > > > > > KVM guest.
>
> With "Virtio Block Backed Pmem" we could name the config
> option VIRTIO_BLOCK_PMEM
>
> The documentation text could make it clear to people that the
> image shows up as a disk image on the host, but as a pmem
> memory range in the guest.
>
> > > > > I think we need to call this something other than persistent
> > > > > memory to
> > > > > make it clear that this not memory where the persistence can be
> > > > > managed from userspace. The persistence point always requires
> > > > >
> > > So currently /proc/iomem in a guest with a pmem device attached to
> > > a
> > > namespace looks like this:
> > >
> > > c00000000-13bfffffff : Persistent Memory
> > > c00000000-13bfffffff : namespace2.0
> > >
> > > Can we call it "Virtio Shared Memory" to make it clear it is a
> > > different beast than typical "Persistent Memory"? You can likely
> >
> > I think somewhere we need persistent keyword 'Virtio Persistent
> > Memory' or
> > so.
>
> Still hoping for better ideas than "Virtio Block Backed Pmem" :)
>
Dan,
I have a query regarding below patch [*]. My assumption is its halted
because of memory hotplug restructuring work? Anything I am missing
here?
[*] https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg02978.html
next prev parent reply other threads:[~2017-10-12 22:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 15:50 [RFC 0/2] KVM "fake DAX" device flushing Pankaj Gupta
2017-10-12 15:50 ` [RFC 1/2] pmem: Move reusable code to base header files Pankaj Gupta
2017-10-12 20:42 ` Dan Williams
2017-10-12 21:27 ` [Qemu-devel] " Pankaj Gupta
[not found] ` <20171012155027.3277-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-12 15:50 ` [RFC 2/2] KVM: add virtio-pmem driver Pankaj Gupta
2017-10-12 20:51 ` Dan Williams
2017-10-12 21:25 ` Pankaj Gupta
2017-10-12 21:54 ` Dan Williams
[not found] ` <CAPcyv4gkri7t+3Unf0sc9AHMnz-v9G_qV_bJppLjUUNAn7drrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-12 22:18 ` Pankaj Gupta
2017-10-12 22:27 ` Rik van Riel
2017-10-12 22:39 ` Pankaj Gupta
2017-10-12 22:52 ` Pankaj Gupta [this message]
2017-10-12 22:59 ` Dan Williams
2017-10-12 23:07 ` Pankaj Gupta
2017-10-13 9:44 ` Stefan Hajnoczi
2017-10-13 10:48 ` Pankaj Gupta
[not found] ` <24301306.20068579.1507891695416.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-16 14:47 ` Stefan Hajnoczi
2017-10-16 15:58 ` Dan Williams
2017-10-16 17:04 ` Pankaj Gupta
[not found] ` <20171013094431.GA27308-lxVrvc10SDRcolVlb+j0YCZi+YwRKgec@public.gmane.org>
2017-10-13 15:25 ` Dan Williams
[not found] ` <20171012155027.3277-3-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-17 7:16 ` Christoph Hellwig
2017-10-17 7:40 ` [Qemu-devel] " Pankaj Gupta
2017-10-17 8:02 ` Christoph Hellwig
2017-10-17 8:30 ` Pankaj Gupta
2017-10-18 13:03 ` Stefan Hajnoczi
2017-10-18 15:51 ` Dan Williams
[not found] ` <CAPcyv4h6aFkyHhh4R4DTznbSCLf9CuBoszk0Q1gB5EKNcp_SeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-19 8:01 ` Stefan Hajnoczi
2017-10-19 8:01 ` Christoph Hellwig
[not found] ` <20171019080149.GB10089-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-10-19 18:21 ` Dan Williams
[not found] ` <CAPcyv4j=Cdp68C15HddKaErpve2UGRfSTiL6bHiS=3gQybz9pg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-20 8:00 ` Christoph Hellwig
[not found] ` <20171020080049.GA25471-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-10-20 15:05 ` Dan Williams
2017-10-20 16:06 ` Christoph Hellwig
2017-10-20 16:11 ` Dan Williams
2017-10-12 15:50 ` [RFC] QEMU: Add virtio pmem device Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111804283.19946669.1507848765955.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@redhat.com \
--cc=ross.zwisler@intel.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).