nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Pankaj Gupta <pagupta@redhat.com>
To: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: jglisse@redhat.com, yu c zhang <yu.c.zhang@intel.com>,
	kvm@vger.kernel.org, linux-nvdimm@lists.01.org, jack@suse.cz,
	david@redhat.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, rkrcmar@redhat.com, pbonzini@redhat.com,
	hch@lst.de, yi z zhang <yi.z.zhang@intel.com>
Subject: Re: [PATCH V4 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX
Date: Tue, 18 Sep 2018 22:43:31 -0400 (EDT)	[thread overview]
Message-ID: <1394508970.13987303.1537325011734.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <c0b53c74379e6d654bbe42471fcef8aa5fd22efd.1534934405.git.yi.z.zhang@linux.intel.com>


> 
> Currently, NVDIMM pages will be marked 'PageReserved'. However, unlike
> other reserved PFNs, pages on NVDIMM shall still behave like normal ones
> in many cases, i.e. when used as backend memory of KVM guest. This patch
> introduces a new memory type, MEMORY_DEVICE_DEV_DAX. And set this flag
> while dax driver hotplug the device memory.
> 
> Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
> Signed-off-by: Zhang Yu <yu.c.zhang@linux.intel.com>
> Reviewed-by: Jan Kara suse.cz>
> ---
>  drivers/dax/pmem.c       | 1 +
>  include/linux/memremap.h | 8 ++++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/dax/pmem.c b/drivers/dax/pmem.c
> index fd49b24..fb3f363 100644
> --- a/drivers/dax/pmem.c
> +++ b/drivers/dax/pmem.c
> @@ -111,6 +111,7 @@ static int dax_pmem_probe(struct device *dev)
>                  return rc;
>  
>          dax_pmem->pgmap.ref = &dax_pmem->ref;
> +        dax_pmem->pgmap.type = MEMORY_DEVICE_DEV_DAX;
>          addr = devm_memremap_pages(dev, &dax_pmem->pgmap);
>          if (IS_ERR(addr))
>                  return PTR_ERR(addr);
> diff --git a/include/linux/memremap.h b/include/linux/memremap.h
> index f91f9e7..cd07ca8 100644
> --- a/include/linux/memremap.h
> +++ b/include/linux/memremap.h
> @@ -53,11 +53,19 @@ struct vmem_altmap {
>   * wakeup event whenever a page is unpinned and becomes idle. This
>   * wakeup is used to coordinate physical address space management (ex:
>   * fs truncate/hole punch) vs pinned pages (ex: device dma).
> + *
> + * MEMORY_DEVICE_DEV_DAX:
> + * Device memory that support raw access to persistent memory. Without need
> + * of an intervening filesystem, it could be directed mapped via an mmap
> + * capable character device. Together with the type MEMORY_DEVICE_FS_DAX,
> + * we could distinguish the persistent memory pages from normal ZONE_DEVICE
> + * pages.
>   */
>  enum memory_type {
>          MEMORY_DEVICE_PRIVATE = 1,
>          MEMORY_DEVICE_PUBLIC,
>          MEMORY_DEVICE_FS_DAX,
> +        MEMORY_DEVICE_DEV_DAX,
>  };
>  
>  /*
> --

Reviewed-by: Pankaj Gupta <pagupta@redhat.com>

> 2.7.4
> 
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-09-19  2:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 10:55 [PATCH V4 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-08-22 10:55 ` [PATCH V4 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-08-22 10:56 ` [PATCH V4 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-09-19  2:43   ` Pankaj Gupta [this message]
2018-08-22 10:56 ` [PATCH V4 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-09-19  2:48   ` Pankaj Gupta
2018-08-22 10:58 ` [PATCH V4 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-08-29 10:15   ` Pankaj Gupta
2018-08-30 19:23     ` Yi Zhang
2018-08-30 19:07   ` Dave Hansen
2018-08-31 16:39     ` Yi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394508970.13987303.1537325011734.JavaMail.zimbra@redhat.com \
    --to=pagupta@redhat.com \
    --cc=david@redhat.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=jglisse@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=yi.z.zhang@intel.com \
    --cc=yi.z.zhang@linux.intel.com \
    --cc=yu.c.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).