From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB50C20348608 for ; Wed, 9 May 2018 15:47:03 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [PATCH v5 2/4] ndctl: convert namespace actions to use util_filter_walk() Date: Wed, 9 May 2018 22:47:02 +0000 Message-ID: <1525906020.4429.1.camel@intel.com> References: <152486678857.66587.12260245215754521561.stgit@djiang5-desk3.ch.intel.com> <152486690348.66587.15082403237213429099.stgit@djiang5-desk3.ch.intel.com> In-Reply-To: <152486690348.66587.15082403237213429099.stgit@djiang5-desk3.ch.intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "Jiang, Dave" Cc: "linux-nvdimm@lists.01.org" List-ID: On Fri, 2018-04-27 at 15:08 -0700, Dave Jiang wrote: > util_filter_walk() does the looping through of busses and regions. > Removing > duplicate code in namespace ops and provide filter functions so we can > utilize util_filter_walk() and share common code. > > Signed-off-by: Dave Jiang > --- > ndctl/namespace.c | 163 ++++++++++++++++++++++++++++++----------------- > ------ > test/btt-check.sh | 2 - > util/filter.c | 5 +- > util/filter.h | 8 +++ > 4 files changed, 104 insertions(+), 74 deletions(-) > [...] > > diff --git a/test/btt-check.sh b/test/btt-check.sh > index 353d4375..50c1b592 100755 > --- a/test/btt-check.sh > +++ b/test/btt-check.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash -E > +#!/bin/bash -Ex Did you mean to add this hunk? > > # Copyright(c) 2015-2017 Intel Corporation. All rights reserved. > # > diff --git a/util/filter.c b/util/filter.c > index 0d3cc02f..b7a4fbd6 100644 > --- a/util/filter.c > +++ b/util/filter.c > [...] _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm