From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA67F211F8881 for ; Fri, 6 Jul 2018 13:26:22 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [ndctl PATCH] ndctl, test: Fix dax.sh return code Date: Fri, 6 Jul 2018 20:26:00 +0000 Message-ID: <1530908758.7574.40.camel@intel.com> References: <153073826178.9647.3462886609135347418.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <153073826178.9647.3462886609135347418.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Language: en-US Content-ID: <16F3221FEC69F04981695D4EB8F15D80@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" Cc: "linux-nvdimm@lists.01.org" List-ID: On Wed, 2018-07-04 at 14:04 -0700, Dan Williams wrote: > Commit 11b349b5236e "ndctl, test: Disable poison tests for now" > inadvertently prevented the dax.sh test from ever succeeding. Revert > the > change to return $rc instead of 0. > > Fixes: 11b349b5236e ("ndctl, test: Disable poison tests for now") > Signed-off-by: Dan Williams > --- > test/dax.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/dax.sh b/test/dax.sh > index 30fe16721935..2a82281edb35 100755 > --- a/test/dax.sh > +++ b/test/dax.sh > @@ -90,4 +90,4 @@ json=$($NDCTL create-namespace -m raw -f -e $dev) > eval $(echo $json | sed -e "$json2var") > [ $mode != "fsdax" ] && echo "fail: $LINENO" && exit 1 > > -exit $rc > +exit 0 I'm not sure I understand why this will cause it to always fail. rc is set in run_test, and that takes care of erroring out when the test returns anything other than 0 or 77. In case of 0 or 77, it falls through. So in the end here, we do want 'exit $rc' so we propagate the 77 correctly. Am I missing something? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm