From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Busch, Keith" <keith.busch@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "zwisler@kernel.org" <zwisler@kernel.org>,
"gustavo@embeddedor.com" <gustavo@embeddedor.com>
Subject: Re: [PATCHv4 2/2] libnvdimm: Export max available extent
Date: Tue, 24 Jul 2018 21:39:41 +0000 [thread overview]
Message-ID: <1532468379.8557.23.camel@intel.com> (raw)
In-Reply-To: <20180724210758.14098-2-keith.busch@intel.com>
On Tue, 2018-07-24 at 15:07 -0600, Keith Busch wrote:
> The 'available_size' attribute showing the combined total of all
> unallocated space isn't always useful to know how large of a
> namespace
> a user may be able to allocate if the region is fragmented. This
> patch
> will export the largest extent of unallocated space that may be
> allocated
> to create a new namespace.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
> No change since previous version
>
> drivers/nvdimm/region_devs.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
Looks good to me. Feel free to add:
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> diff --git a/drivers/nvdimm/region_devs.c
> b/drivers/nvdimm/region_devs.c
> index c30d5af02cc2..fa37afcd43ff 100644
> --- a/drivers/nvdimm/region_devs.c
> +++ b/drivers/nvdimm/region_devs.c
> @@ -434,6 +434,21 @@ static ssize_t available_size_show(struct device
> *dev,
> }
> static DEVICE_ATTR_RO(available_size);
>
> +static ssize_t max_available_extent_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct nd_region *nd_region = to_nd_region(dev);
> + unsigned long long available = 0;
> +
> + nvdimm_bus_lock(dev);
> + wait_nvdimm_bus_probe_idle(dev);
> + available = nd_region_allocatable_dpa(nd_region);
> + nvdimm_bus_unlock(dev);
> +
> + return sprintf(buf, "%llu\n", available);
> +}
> +static DEVICE_ATTR_RO(max_available_extent);
> +
> static ssize_t init_namespaces_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> @@ -585,6 +600,7 @@ static struct attribute *nd_region_attributes[] =
> {
> &dev_attr_read_only.attr,
> &dev_attr_set_cookie.attr,
> &dev_attr_available_size.attr,
> + &dev_attr_max_available_extent.attr,
> &dev_attr_namespace_seed.attr,
> &dev_attr_init_namespaces.attr,
> &dev_attr_badblocks.attr,
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-07-24 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 21:07 [PATCHv4 1/2] libnvdimm: Use max contiguous area for namespace size Keith Busch
2018-07-24 21:07 ` [PATCHv4 2/2] libnvdimm: Export max available extent Keith Busch
2018-07-24 21:39 ` Verma, Vishal L [this message]
2018-07-24 21:38 ` [PATCHv4 1/2] libnvdimm: Use max contiguous area for namespace size Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532468379.8557.23.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dave.jiang@intel.com \
--cc=gustavo@embeddedor.com \
--cc=keith.busch@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).