nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"oceanhehy@gmail.com" <oceanhehy@gmail.com>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"hehy1@lenovo.com" <hehy1@lenovo.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] ACPI: nfit: adjust annotation for why return 0 if fail to find NFIT at startup
Date: Tue, 7 Aug 2018 19:25:15 +0000	[thread overview]
Message-ID: <1533669914.18175.28.camel@intel.com> (raw)
In-Reply-To: <1533622531-3617-1-git-send-email-oceanhehy@gmail.com>


On Tue, 2018-08-07 at 02:15 -0400, Ocean He wrote:
> From: Ocean He <hehy1@lenovo.com>

Just some minor nits in commit message wording:

> 
> Add detail explanation why it's ok to return 0 if fail to find NFIT at
      detailed          ^for                       ^we          ^an
> startup, refer to chapter 9.20.2 NVDIMM Root Device in ACPI 6.2 spec.
         . Refer

Perhaps Dave can fixup while applying..
> 
> Signed-off-by: Ocean He <hehy1@lenovo.com>
> ---
> v1: https://lists.01.org/pipermail/linux-nvdimm/2018-August/017311.html 
> v2: Per Vishal's comments of v1, it turns out that it's right to keep 
> "return 0" if NFIT not found at boot time. This v2 adjust annotation
> to avoid misunderstanding of "return 0".

Looks good, thanks for the update. Feel free to add:
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

> 
>  drivers/acpi/nfit/core.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 7c47900..1b982fe 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -3353,7 +3353,13 @@ static int acpi_nfit_add(struct acpi_device *adev)
>  
>  	status = acpi_get_table(ACPI_SIG_NFIT, 0, &tbl);
>  	if (ACPI_FAILURE(status)) {
> -		/* This is ok, we could have an nvdimm hotplugged later */
> +		/* The NVDIMM root device allows OS to trigger enumeration of
> +		 * NVDIMMs through NFIT at boot time and re-enumeration at
> +		 * root level via the _FIT method during runtime.
> +		 * This is ok to return 0 here, we could have an nvdimm
> +		 * hotplugged later and evaluate _FIT method which returns
> +		 * data in the format of a series of NFIT Structures.
> +		 */
>  		dev_dbg(dev, "failed to find NFIT at startup\n");
>  		return 0;
>  	}
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-08-07 19:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07  6:15 Ocean He
2018-08-07 19:25 ` Verma, Vishal L [this message]
2018-08-07 22:46   ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533669914.18175.28.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=hehy1@lenovo.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=oceanhehy@gmail.com \
    --cc=rjw@rjwysocki.net \
    --cc=ross.zwisler@linux.intel.com \
    --subject='Re: [PATCH] ACPI: nfit: adjust annotation for why return 0 if fail to find NFIT at startup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).