From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Subject: [ndctl PATCH v3 0/3] Replace udev rule for latch and dirty-shutdown-count
Date: Thu, 27 Sep 2018 17:41:37 -0700 [thread overview]
Message-ID: <153809529764.1963951.7530312689559729607.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
Changes since v2 [1]:
* Drop the 'dirty-dimm' command
* Add ndctl_dimm_get_dirty_shutdown() api
[1]: https://lists.01.org/pipermail/linux-nvdimm/2018-September/017890.html
---
The latch mechanism is awkward especially when all that it needed is a
rolling count of dirty-shutdown events. The expectation going forward is
that the platform firmware will handle the latch, if it is present, and
the OS need only consume the dirty-shutdown count. The ndctl
implementation called libndctl apis from the udev queue which we
discovered injects unnecessary udev queue drains / stalls into the boot
path. Lastly, the userspace caching scheme for non-root users to consume
the dirty-shutdown-count just isn't as efficient as teaching the kernel
to cache this value and export it as a standard sysfs attribute.
---
Dan Williams (3):
ndctl, lib: Add dirty-shutdown-count retrieval helper
ndctl: Revert "ndctl, intel: Fallback to smart cached shutdown_count"
ndctl: Revert "ndctl: Create ndctl udev rules for dirty shutdown"
.gitignore | 1
Makefile.am | 3 -
configure.ac | 10 ---
contrib/80-ndctl.rules | 3 -
ndctl.spec.in | 3 -
ndctl/Makefile.am | 5 --
ndctl/lib/intel.c | 41 -------------
ndctl/lib/libndctl.c | 16 ++++-
ndctl/lib/libndctl.sym | 5 ++
ndctl/lib/private.h | 4 -
ndctl/libndctl.h | 1
ndctl/ndctl-udev.c | 150 ------------------------------------------------
test/libndctl.c | 29 +++++++--
13 files changed, 40 insertions(+), 231 deletions(-)
delete mode 100644 contrib/80-ndctl.rules
delete mode 100644 ndctl/ndctl-udev.c
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next reply other threads:[~2018-09-28 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 0:41 Dan Williams [this message]
2018-09-28 0:41 ` [ndctl PATCH v3 1/3] ndctl, lib: Add dirty-shutdown-count retrieval helper Dan Williams
2018-09-28 0:41 ` [ndctl PATCH v3 2/3] ndctl: Revert "ndctl, intel: Fallback to smart cached shutdown_count" Dan Williams
2018-09-28 0:41 ` [ndctl PATCH v3 3/3] ndctl: Revert "ndctl: Create ndctl udev rules for dirty shutdown" Dan Williams
2018-10-03 1:08 ` [ndctl PATCH v3 0/3] Replace udev rule for latch and dirty-shutdown-count Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153809529764.1963951.7530312689559729607.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).