From: Kemeng Shi <shikemeng@huawei.com>
To: <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
<dave.jiang@intel.com>, <ira.weiny@intel.com>,
<nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] libnvdimm, badrange: replace div_u64_rem with DIV_ROUND_UP
Date: Sat, 26 Jun 2021 11:53:13 +0800 [thread overview]
Message-ID: <194fed48-eaf3-065f-9571-7813ad35b098@huawei.com> (raw)
__add_badblock_range use div_u64_rem to round up end_sector and it
will introduces unnecessary rem define and costly '%' operation.
So clean it with DIV_ROUND_UP.
Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
---
V1->V2:
-- fix that end_sector is assigned twice, sorry for that.
drivers/nvdimm/badrange.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/nvdimm/badrange.c b/drivers/nvdimm/badrange.c
index aaf6e215a8c6..af622ae511aa 100644
--- a/drivers/nvdimm/badrange.c
+++ b/drivers/nvdimm/badrange.c
@@ -187,12 +187,9 @@ static void __add_badblock_range(struct badblocks *bb, u64 ns_offset, u64 len)
const unsigned int sector_size = 512;
sector_t start_sector, end_sector;
u64 num_sectors;
- u32 rem;
start_sector = div_u64(ns_offset, sector_size);
- end_sector = div_u64_rem(ns_offset + len, sector_size, &rem);
- if (rem)
- end_sector++;
+ end_sector = DIV_ROUND_UP(ns_offset + len, sector_size);
num_sectors = end_sector - start_sector;
if (unlikely(num_sectors > (u64)INT_MAX)) {
--
2.23.0
--
Best wishes
Kemeng Shi
next reply other threads:[~2021-06-26 3:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 3:53 Kemeng Shi [this message]
2021-07-08 13:11 ` [PATCH v2] libnvdimm, badrange: replace div_u64_rem with DIV_ROUND_UP Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=194fed48-eaf3-065f-9571-7813ad35b098@huawei.com \
--to=shikemeng@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).