nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Vishal Verma <vishal.l.verma@intel.com>
To: linux-nvdimm@lists.01.org
Subject: [ndctl PATCH] ndctl, rescan-partitions.sh: fix skipping for missing modules
Date: Wed,  4 Apr 2018 22:37:44 -0600	[thread overview]
Message-ID: <20180405043744.23069-1-vishal.l.verma@intel.com> (raw)

rescan-partitions would fail if the nfit_test module was not found. Fix
by moving the modprobe attempt to earlier in the test.

Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
 test/rescan-partitions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/rescan-partitions.sh b/test/rescan-partitions.sh
index 47f0b62..7ae0957 100755
--- a/test/rescan-partitions.sh
+++ b/test/rescan-partitions.sh
@@ -54,7 +54,6 @@ check_prereq "blockdev"
-	modprobe nfit_test
 	$ndctl disable-region -b "$bus" all
 	$ndctl zero-labels -b "$bus" all
 	$ndctl enable-region -b "$bus" all
@@ -97,6 +96,7 @@ test_mode()
 	$ndctl destroy-namespace $dev
+modprobe nfit_test
 test_mode "raw"

Linux-nvdimm mailing list

                 reply	other threads:[~2018-04-05  4:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180405043744.23069-1-vishal.l.verma@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=linux-nvdimm@lists.01.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).